$EDITOR is allowed to contain flags, so it is important to allow the shell to split this normally. For example, Sublime Text needs to be passed --wait, since otherwise it will daemonise.