Whenever we create scripts that are installed to $out, we must use runtimeShell
in order to get the shell that can be executed on the machine we create the
package for. This is relevant for cross-compiling. The only use case for
stdenv.shell are scripts that are executed as part of the build system.
Usages in checkPhase are borderline however to decrease the likelyhood
of people copying the wrong examples, I decided to use runtimeShell as well.
The original issue can be reproduced when sending with an unpatched
`mutt` or `neomutt` an email with an attachement which as han `.asc`
extension. This will be interpreted as `application/pgp-encrypted` which
experiences special logic, in the end the attachement will contain
"Version: 1"[1][2][3]
Right now, there are the following issues in the {,neo}mutt packages:
* `mutt.override { smimeSupport = true }` fails to build since the
Debian patch results in a 404. Debian moved their packages to
`salsa.debian.org`.
However we can't use a versioned URL for this as Debian only tracks
the Mutt versions that are available in their releases. The patch
doesn't touch Mutt's core and is therefore simple to rebase, so
sticking to the 1.10.2 patch for now should be sufficient.
* The original issue was never fixed in NeoMutt, currently we use the
S/MIME database from `pkgs.mime-types` which contains the issue with
`application/pgp-encrypted` as well.
After some discussion[4] it seems to be the best decision to use the
`mailcap` database distributed by Fedora[5] which fixes the issue
rather than `mime-types` v9 from 2012.
[1] https://bugs.archlinux.org/task/43319
[2] https://bugs.gentoo.org/534658
[3] https://github.com/neomutt/neomutt/blob/neomutt-20180716/sendlib.c#L490-L496
[4] https://github.com/NixOS/nixpkgs/pull/50927#issuecomment-441383260
[5] https://pagure.io/mailcap
In a few cases it wasn't clear so I left them as-is.
While visiting these moved other things to nativeBuildInputs
when it was clear they were one of these cases:
* makeWrapper
* archive utilities (in order to unpack src)
* a few of these might no longer be needed but leaving for another day
Couple of things were updated to make this work.
1. webkitgtk24x-gtk3 that is marked unsafe has been replaced with
webkitgtk (2.20.*) as astroid has recently indicated that [>= 2.20
is
acceptable](48ce7e3010)
2. protobuf built input was added to satisfy requirements
3. astroid was not functional at all without proper icons so gnome3.defaultIconTheme
were added to buildInputs
4. By default, astroid will use `gvim` as a setting for the embedded
editor, however that didn't work well with nixpkgs. vim is now
bundled with astroid by default. This setting can be overridden
by the user in astroid's config file.
This makes the command ‘nix-env -qa -f. --arg config '{skipAliases =
true;}'’ work in Nixpkgs.
Misc...
- qtikz: use libsForQt5.callPackage
This ensures we get the right poppler.
- rewrites:
docbook5_xsl -> docbook_xsl_ns
docbook_xml_xslt -> docbook_xsl
diffpdf: fixup
* treewide: http -> https sources
This updates the source urls of all top-level packages from http to
https where possible.
* buildtorrent: fix url and tab -> spaces
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/balsa/versions.
These checks were done:
- built on NixOS
- Warning: no invocation of /nix/store/1hgx73336q1zhd8r95wv2kicf6a2jmby-balsa-2.5.6/bin/balsa had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/1hgx73336q1zhd8r95wv2kicf6a2jmby-balsa-2.5.6/bin/balsa-ab had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/1hgx73336q1zhd8r95wv2kicf6a2jmby-balsa-2.5.6/bin/.balsa-wrapped had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/1hgx73336q1zhd8r95wv2kicf6a2jmby-balsa-2.5.6/bin/.balsa-ab-wrapped had a zero exit code or showed the expected version
- 0 of 4 passed binary check by having a zero exit code.
- 0 of 4 passed binary check by having the new version present in output.
- found 2.5.6 with grep in /nix/store/1hgx73336q1zhd8r95wv2kicf6a2jmby-balsa-2.5.6
- directory tree listing: https://gist.github.com/8c38ffd6950508c78fde54f6f3530673
- du listing: https://gist.github.com/2156c87e8b84b7a84f6d6f4c4a7b8ebb
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/notmuch/versions.
These checks were done:
- built on NixOS
- /nix/store/fc0y8jb20kfm3v4yy3zzc6ipidc1ks1c-notmuch-0.27/bin/notmuch passed the binary check.
- Warning: no invocation of /nix/store/fc0y8jb20kfm3v4yy3zzc6ipidc1ks1c-notmuch-0.27/bin/notmuch-emacs-mua had a zero exit code or showed the expected version
- 1 of 2 passed binary check by having a zero exit code.
- 1 of 2 passed binary check by having the new version present in output.
- found 0.27 with grep in /nix/store/fc0y8jb20kfm3v4yy3zzc6ipidc1ks1c-notmuch-0.27
- directory tree listing: https://gist.github.com/2a14e6349ea43a555857f9e30bf328ff
- du listing: https://gist.github.com/d08317825ff4ade027455942eb367fdb
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/mutt/versions.
These checks were done:
- built on NixOS
- /nix/store/ydny2lhs0idsg1hxzkgi198n9jn17rcw-mutt-1.10.0/bin/mutt passed the binary check.
- /nix/store/ydny2lhs0idsg1hxzkgi198n9jn17rcw-mutt-1.10.0/bin/pgpring passed the binary check.
- Warning: no invocation of /nix/store/ydny2lhs0idsg1hxzkgi198n9jn17rcw-mutt-1.10.0/bin/pgpewrap had a zero exit code or showed the expected version
- /nix/store/ydny2lhs0idsg1hxzkgi198n9jn17rcw-mutt-1.10.0/bin/muttbug passed the binary check.
- /nix/store/ydny2lhs0idsg1hxzkgi198n9jn17rcw-mutt-1.10.0/bin/flea passed the binary check.
- Warning: no invocation of /nix/store/ydny2lhs0idsg1hxzkgi198n9jn17rcw-mutt-1.10.0/bin/smime_keys had a zero exit code or showed the expected version
- 4 of 6 passed binary check by having a zero exit code.
- 0 of 6 passed binary check by having the new version present in output.
- found 1.10.0 with grep in /nix/store/ydny2lhs0idsg1hxzkgi198n9jn17rcw-mutt-1.10.0
- directory tree listing: https://gist.github.com/2b53d5dc44b600872e77911ba7099e1c
- du listing: https://gist.github.com/4caca5d9043a5281a6b192ebaf30065f
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/neomutt/versions.
These checks were done:
- built on NixOS
- ran ‘/nix/store/ww06xw1m1b0r4fy308kwa6vvj4cyy1yk-neomutt-20180512/bin/neomutt -h’ got 0 exit code
- ran ‘/nix/store/ww06xw1m1b0r4fy308kwa6vvj4cyy1yk-neomutt-20180512/bin/neomutt --help’ got 0 exit code
- ran ‘/nix/store/ww06xw1m1b0r4fy308kwa6vvj4cyy1yk-neomutt-20180512/bin/.neomutt-wrapped -h’ got 0 exit code
- ran ‘/nix/store/ww06xw1m1b0r4fy308kwa6vvj4cyy1yk-neomutt-20180512/bin/.neomutt-wrapped --help’ got 0 exit code
- found 20180512 with grep in /nix/store/ww06xw1m1b0r4fy308kwa6vvj4cyy1yk-neomutt-20180512
- directory tree listing: https://gist.github.com/8d13b2cd77148163ee7c664ce4cdba07
- du listing: https://gist.github.com/9755eddec256452bf53913477fd2bebb
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/notmuch/versions.
These checks were done:
- built on NixOS
- ran ‘/nix/store/05v4k89ni4phwyxvqskr0hji49b5fmck-notmuch-0.26.1/bin/notmuch --help’ got 0 exit code
- ran ‘/nix/store/05v4k89ni4phwyxvqskr0hji49b5fmck-notmuch-0.26.1/bin/notmuch help’ got 0 exit code
- ran ‘/nix/store/05v4k89ni4phwyxvqskr0hji49b5fmck-notmuch-0.26.1/bin/notmuch --version’ and found version 0.26.1
- found 0.26.1 with grep in /nix/store/05v4k89ni4phwyxvqskr0hji49b5fmck-notmuch-0.26.1
- directory tree listing: https://gist.github.com/adeae189f9ac416571a7c0e3beca712f
Florian Klink
Matthias Beyer
taku0
Vladimír Čunát
Jörg Thalheim
R. RyanTM
Robin Gloster
Will Dietz
Michael Fellinger
Daniel Schaefer
xeji
Maximilian Bosch
Ryan Mulligan
Silvan Mosberger
Jascha Geerds
Jakub Fišer
Frederik Rietdijk
Robert Schütz
Frederik Rietdijk
Mario Rodas
Alyssa Ross
rnhmjoj
Florian Friesdorf
Matthew Bauer
Andreas Rammhold
Jan Tojnar
Jan Malakhovski
taku0
Justin Humm
Vladimír Čunát
Lengyel Balazs
Franz Pletz
Alexey Shmalko
Tor Hedin Brønner
Piotr Bogdan
c0bw3b
Andrey Golovizin
Mateusz Kowalczyk
Will Dietz
Eelco Dolstra
Yurii Rashkovskii
Uli Baum
Markus Kowalewski
John Ericson
Jörg Thalheim
R. RyanTM
volth
Matthew Bauer
ajs124
Thomas Kerber
Ben Gamari
José Romildo Malaquias
Michael Weiss
Peter Hoeg