From e4410bfd8565ce317d31e4a670ba50ebbfec74df Mon Sep 17 00:00:00 2001 From: Artjom Vejsel Date: Mon, 24 Aug 2015 07:49:21 +0300 Subject: [PATCH 1/2] qt4SDK/qt5SDK: delete (see #9342) --- pkgs/top-level/all-packages.nix | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index b27ca65f794..750c3b8484e 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -7948,11 +7948,6 @@ let developerBuild = true; }); - qt4SDK = qtcreator.override { - sdkBuild = true; - qtLib = qt48Full; - }; - qt53 = callPackage ../development/libraries/qt-5/5.3 { mesa = mesa_noglu; cups = if stdenv.isLinux then cups else null; @@ -7972,12 +7967,6 @@ let developerBuild = true; }); - qt5SDK = qtcreator.override { - sdkBuild = true; - qtLib = qt5Full; - withDocumentation = true; - }; - qtcreator = callPackage ../development/qtcreator { qtLib = qt5Full; # 3.4 only supports qt5; TODO: use modularized qt>=5.4 withDocumentation = true; From 9c206b6cf7ab22aa20d8ed4ab7169b716c999762 Mon Sep 17 00:00:00 2001 From: Artjom Vejsel Date: Mon, 24 Aug 2015 07:50:17 +0300 Subject: [PATCH 2/2] qtcreator: refactor for using qt54 --- lib/maintainers.nix | 1 + pkgs/development/qtcreator/default.nix | 27 +++++++++++--------------- pkgs/top-level/all-packages.nix | 2 +- 3 files changed, 13 insertions(+), 17 deletions(-) diff --git a/lib/maintainers.nix b/lib/maintainers.nix index d42d81399cf..21ee19708a4 100644 --- a/lib/maintainers.nix +++ b/lib/maintainers.nix @@ -14,6 +14,7 @@ aflatter = "Alexander Flatter "; aherrmann = "Andreas Herrmann "; ak = "Alexander Kjeldaas "; + akaWolf = "Artjom Vejsel "; akc = "Anders Claesson "; algorith = "Dries Van Daele "; all = "Nix Committers "; diff --git a/pkgs/development/qtcreator/default.nix b/pkgs/development/qtcreator/default.nix index 199df25d552..0f55d4ee9af 100644 --- a/pkgs/development/qtcreator/default.nix +++ b/pkgs/development/qtcreator/default.nix @@ -1,4 +1,4 @@ -{ stdenv, fetchurl, qtLib, sdkBuild ? false, withDocumentation ? true }: +{ stdenv, fetchurl, makeWrapper, qtLib, withDocumentation ? false }: with stdenv.lib; @@ -9,31 +9,21 @@ let in stdenv.mkDerivation rec { - # The package name depends on wether we are just building the QtCreator package or the whole Qt SDK - # If we are building the QtCreator package: qtcreator-version - # If we are building the QtSDK package, the Qt version is also included: qtsdk-version-qt-version - name = "qt${if sdkBuild then "sdk" else "creator"}-${version}" - + optionalString sdkBuild "-qt-${qtLib.version}"; + name = "qtcreator-${version}"; src = fetchurl { url = "http://download.qt-project.org/official_releases/qtcreator/${baseVersion}/${version}/qt-creator-opensource-src-${version}.tar.gz"; sha256 = "1asbfphws0aqs92gjgh0iqzr1911kg51r9al44jxpfk88yazjzgm"; }; - # This property can be used in a nix development environment to refer to the Qt package - # eg: export QTDIR=${qtSDK.qt} - qt = qtLib; - - # We must only propagate Qt (including qmake) when building the QtSDK - propagatedBuildInputs = if sdkBuild then [ qtLib ] else []; - buildInputs = if sdkBuild == false then [ qtLib ] else []; + buildInputs = [ makeWrapper qtLib.base qtLib.script qtLib.quickcontrols qtLib.declarative ]; doCheck = false; enableParallelBuilding = true; preConfigure = '' - qmake -spec linux-g++ "QT_PRIVATE_HEADERS=${qtLib}/include" qtcreator.pro + qmake -spec linux-g++ qtcreator.pro ''; buildFlags = optionalString withDocumentation " docs"; @@ -54,6 +44,11 @@ stdenv.mkDerivation rec { Type=Application Categories=Qt;Development;IDE; __EOF__ + # Wrap the qtcreator binary + wrapProgram $out/bin/qtcreator \ + --prefix QT_PLUGIN_PATH : "$QT_PLUGIN_PATH" \ + --prefix QML_IMPORT_PATH : "$QML_IMPORT_PATH" \ + --prefix QML2_IMPORT_PATH : "$QML2_IMPORT_PATH" ''; meta = { @@ -63,9 +58,9 @@ stdenv.mkDerivation rec { tailored to the needs of Qt developers. It includes features such as an advanced code editor, a visual debugger and a GUI designer. ''; - homepage = "http://qt-project.org/wiki/Category:Tools::QtCreator"; + homepage = "https://wiki.qt.io/Category:Tools::QtCreator"; license = "LGPL"; - maintainers = [ maintainers.bbenoist ]; + maintainers = [ maintainers.akaWolf maintainers.bbenoist ]; platforms = platforms.all; }; } diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 750c3b8484e..aa5d09855d9 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -7968,7 +7968,7 @@ let }); qtcreator = callPackage ../development/qtcreator { - qtLib = qt5Full; # 3.4 only supports qt5; TODO: use modularized qt>=5.4 + qtLib = qt54; withDocumentation = true; };