From 250c19c7467d616abf5d645832f75b04c31fc6e8 Mon Sep 17 00:00:00 2001 From: Echo Nolan Date: Fri, 16 Mar 2018 19:56:51 -0700 Subject: [PATCH 1/2] workrave: 1.10.7 -> 1.10.20 Also: switch to GTK-3, fix GSettings by using wrapGAppsHook. --- pkgs/applications/misc/workrave/default.nix | 28 +++++++-------------- pkgs/top-level/all-packages.nix | 1 - 2 files changed, 9 insertions(+), 20 deletions(-) diff --git a/pkgs/applications/misc/workrave/default.nix b/pkgs/applications/misc/workrave/default.nix index 0394fa83d4a..7378a8cb476 100644 --- a/pkgs/applications/misc/workrave/default.nix +++ b/pkgs/applications/misc/workrave/default.nix @@ -1,39 +1,29 @@ -{ stdenv, fetchFromGitHub, fetchpatch -, autoconf, automake, gettext, intltool, libtool, pkgconfig +{ stdenv, fetchFromGitHub, wrapGAppsHook +, autoconf, autoconf-archive, automake, gettext, intltool, libtool, pkgconfig , libICE, libSM, libXScrnSaver, libXtst, cheetah -, glib, glibmm, gtkmm2, atk, pango, pangomm, cairo, cairomm -, dbus, dbus-glib, GConf, gconfmm, gdome2, gstreamer, libsigcxx }: +, gobjectIntrospection, glib, glibmm, gtkmm3, atk, pango, pangomm, cairo +, cairomm , dbus, dbus-glib, gdome2, gstreamer, libsigcxx }: stdenv.mkDerivation rec { name = "workrave-${version}"; - version = "1.10.7"; + version = "1.10.20"; src = let in fetchFromGitHub { - sha256 = "1mxg882rfih7xzadrpj51m9r33f6s3rzwv61nfwi94vzd68qjnxb"; + sha256 = "099a87zkrkmsgfz9isrfm89dh545x52891jh6qxmn19h6wwsi941"; rev = with stdenv.lib; "v" + concatStringsSep "_" (splitString "." version); repo = "workrave"; owner = "rcaelers"; }; - patches = [ - # Building with gtk{,mm}3 works just fine, but let's be conservative for once: - (fetchpatch { - name = "workrave-fix-compilation-with-gtk2.patch"; - url = "https://github.com/rcaelers/workrave/commit/" - + "271efdcd795b3592bfede8b1af2162af4b1f0f26.patch"; - sha256 = "1a3d4jj8516m3m24bl6y8alanl1qnyzv5dv1hz5v3hjgk89fj6rk"; - }) - ]; - nativeBuildInputs = [ - autoconf automake gettext intltool libtool pkgconfig + autoconf autoconf-archive automake gettext intltool libtool pkgconfig wrapGAppsHook ]; buildInputs = [ libICE libSM libXScrnSaver libXtst cheetah - glib glibmm gtkmm2 atk pango pangomm cairo cairomm - dbus dbus-glib GConf gconfmm gdome2 gstreamer libsigcxx + gobjectIntrospection glib glibmm gtkmm3 atk pango pangomm cairo cairomm + dbus dbus-glib gdome2 gstreamer libsigcxx ]; preConfigure = "./autogen.sh"; diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index e8e6b900829..18c3625d38d 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -18189,7 +18189,6 @@ with pkgs; worker = callPackage ../applications/misc/worker { }; workrave = callPackage ../applications/misc/workrave { - inherit (gnome2) GConf gconfmm; inherit (python27Packages) cheetah; }; From 5b0985d05518cc9a8043e00af7c01b663a8bb062 Mon Sep 17 00:00:00 2001 From: Echo Nolan Date: Sat, 17 Mar 2018 13:31:45 -0700 Subject: [PATCH 2/2] workrave: fix alert sounds by including the right GST plugins --- pkgs/applications/misc/workrave/default.nix | 5 +++-- pkgs/top-level/all-packages.nix | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/misc/workrave/default.nix b/pkgs/applications/misc/workrave/default.nix index 7378a8cb476..6e92e98481e 100644 --- a/pkgs/applications/misc/workrave/default.nix +++ b/pkgs/applications/misc/workrave/default.nix @@ -2,7 +2,8 @@ , autoconf, autoconf-archive, automake, gettext, intltool, libtool, pkgconfig , libICE, libSM, libXScrnSaver, libXtst, cheetah , gobjectIntrospection, glib, glibmm, gtkmm3, atk, pango, pangomm, cairo -, cairomm , dbus, dbus-glib, gdome2, gstreamer, libsigcxx }: +, cairomm , dbus, dbus-glib, gdome2, gstreamer, gst-plugins-base +, gst-plugins-good, libsigcxx }: stdenv.mkDerivation rec { name = "workrave-${version}"; @@ -23,7 +24,7 @@ stdenv.mkDerivation rec { buildInputs = [ libICE libSM libXScrnSaver libXtst cheetah gobjectIntrospection glib glibmm gtkmm3 atk pango pangomm cairo cairomm - dbus dbus-glib gdome2 gstreamer libsigcxx + dbus dbus-glib gdome2 gstreamer gst-plugins-base gst-plugins-good libsigcxx ]; preConfigure = "./autogen.sh"; diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 18c3625d38d..5c4e9ebd63b 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -18190,6 +18190,7 @@ with pkgs; workrave = callPackage ../applications/misc/workrave { inherit (python27Packages) cheetah; + inherit (gst_all_1) gstreamer gst-plugins-base gst-plugins-good; }; worldengine-cli = python3Packages.worldengine;