comical: build with wxGTK28

svn path=/nixpkgs/trunk/; revision=29339

pkgs/applications/graphics/comical/default.nix

@@ -1,19 +1,17 @@
 {stdenv, fetchurl, wxGTK, utillinux, zlib }:
 
-stdenv.mkDerivation {
+stdenv.mkDerivation rec {
   name = "comical-0.8";
   src = fetchurl {
-    url = mirror://sourceforge/comical/comical-0.8.tar.gz;
+    url = "mirror://sourceforge/comical/${name}.tar.gz";
     sha256 = "0b6527cc06b25a937041f1eb248d0fd881cf055362097036b939817f785ab85e";
   };
   buildInputs = [ wxGTK utillinux zlib ];
-  patchPhase = ''
+  preBuild="makeFlags=\"prefix=$out\"";
-    sed -i -e 's@"zlib\\.h"@<zlib.h>@' unzip/unzip.h
-    sed -i -e 's@/usr/local@'$out@ \
-      -e 's@-lminiunzip@-lminiunzip -lz@' Makefile
-  '';
 
-  installPhase = "mkdir -p $out/bin ; make install";
+  patches = [ ./wxgtk-2.8.patch ];
+
+  preInstall = "mkdir -pv $out/bin";
 
   meta = {
     description = "Viewer of CBR and CBZ files, often used to store scanned comics";

pkgs/applications/graphics/comical/wxgtk-2.8.patch

@@ -0,0 +1,36 @@
+diff --git a/Makefile b/Makefile
+index a648e72..181c47f 100644
+--- a/Makefile
++++ b/Makefile
+@@ -1,5 +1,5 @@
+ CC = `wx-config --cxx`
+-LDFLAGS = `wx-config --libs` -Lunrar -lunrar -Lunzip -lminiunzip
++LDFLAGS = `wx-config --libs` -Lunrar -lunrar -Lunzip -lminiunzip -lz
+ INSTALL = install
+ INSTALL_PROGRAM = $(INSTALL)
+ prefix = /usr/local
+diff --git a/src/ComicalApp.cpp b/src/ComicalApp.cpp
+index 0c004cd..667e75e 100644
+--- a/src/ComicalApp.cpp
++++ b/src/ComicalApp.cpp
+@@ -28,6 +28,7 @@
+ #include "ComicalApp.h"
+ #include "ComicalFrame.h"
+ #include <wx/log.h>
++#include <wx/icon.h>
+ 
+ #if !defined(__WXMAC__) && !defined(__WXCOCOA__) && !defined(__WXMSW__) && !defined(__WXPM__)
+ #include "../Comical Icons/comical.xpm"
+diff --git a/unzip/unzip.h b/unzip/unzip.h
+index b247937..5bb6a69 100644
+--- a/unzip/unzip.h
++++ b/unzip/unzip.h
+@@ -50,7 +50,7 @@ extern "C" {
+ #endif
+ 
+ #ifndef _ZLIB_H
+-#include "zlib.h"
++#include <zlib.h>
+ #endif
+ 
+ #ifndef _ZLIBIOAPI_H

pkgs/top-level/all-packages.nix

@@ -6276,9 +6276,7 @@ let
     python = pythonFull;
   };
 
-  comical = callPackage ../applications/graphics/comical {
+  comical = callPackage ../applications/graphics/comical { };
-    wxGTK = wxGTK26;
-  };
 
   conkeror = xulrunnerWrapper {
     launcher = "conkeror";