From 9932103ead6c4f8013e9e3768e7bacf0cd0e3e8c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Mon, 4 Jan 2021 10:59:04 +0100 Subject: [PATCH 1/3] ngt: use stdenv.hostPlatform.avxSupport, cleanup --- pkgs/development/libraries/ngt/default.nix | 15 ++++++++++----- pkgs/top-level/all-packages.nix | 2 +- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/pkgs/development/libraries/ngt/default.nix b/pkgs/development/libraries/ngt/default.nix index 977bdf9afe3..7d766eb5d87 100644 --- a/pkgs/development/libraries/ngt/default.nix +++ b/pkgs/development/libraries/ngt/default.nix @@ -1,8 +1,13 @@ -{ stdenv, fetchFromGitHub, cmake, llvmPackages, enableAVX ? false }: +{ stdenv +, fetchFromGitHub +, cmake +, llvmPackages +, enableAVX ? stdenv.hostPlatform.avxSupport +}: + stdenv.mkDerivation rec { pname = "NGT"; version = "v1.12.3-alpha"; - nativeBuildInputs = [ cmake ]; src = fetchFromGitHub { owner = "yahoojapan"; @@ -11,11 +16,11 @@ stdenv.mkDerivation rec { sha256 = "sha256-nu0MJNpaenOB4+evoSVLKmPIuZXVj1Rm9x53+TfhezY="; }; + nativeBuildInputs = [ cmake ]; buildInputs = [ llvmPackages.openmp ]; - NIX_ENFORCE_NO_NATIVE=! enableAVX; - __AVX2__ = if enableAVX then 1 else 0; - enableParallelBuilding = true; + NIX_ENFORCE_NO_NATIVE = ! enableAVX; + __AVX2__ = if enableAVX then 1 else 0; meta = with stdenv.lib; { homepage = "https://github.com/yahoojapan/NGT"; diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 898eb4c7bf4..b5c669083b7 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -23450,7 +23450,7 @@ in nedit = callPackage ../applications/editors/nedit { }; - ngt = callPackage ../development/libraries/ngt { enableAVX = false; }; + ngt = callPackage ../development/libraries/ngt { }; nheko = libsForQt5.callPackage ../applications/networking/instant-messengers/nheko { }; From 9daf938d371f2b8ab1bd849b6214c02413e4d7f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Mon, 4 Jan 2021 10:59:14 +0100 Subject: [PATCH 2/3] katago: Use stdenv.hostPlatform.avx2Support --- pkgs/games/katago/default.nix | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pkgs/games/katago/default.nix b/pkgs/games/katago/default.nix index 0f9e4b8d67a..a9ac9e8ac59 100644 --- a/pkgs/games/katago/default.nix +++ b/pkgs/games/katago/default.nix @@ -14,11 +14,12 @@ , ocl-icd ? null , gperftools ? null , eigen ? null -, enableAVX2 ? false +, enableAVX2 ? stdenv.hostPlatform.avx2Support , enableBigBoards ? false , enableCuda ? false , enableGPU ? true -, enableTcmalloc ? true}: +, enableTcmalloc ? true +}: assert !enableGPU -> ( eigen != null && @@ -103,8 +104,6 @@ in env.mkDerivation rec { --prefix LD_LIBRARY_PATH : "/run/opengl-driver/lib" ''; - enableParallelBuilding = true; - meta = with stdenv.lib; { description = "Go engine modeled after AlphaGo Zero"; homepage = "https://github.com/lightvector/katago"; From a8d360eca3a2245e32295472f0b173426268b9bf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Mon, 4 Jan 2021 11:01:09 +0100 Subject: [PATCH 3/3] raxml: cleanup --- pkgs/applications/science/biology/raxml/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/science/biology/raxml/default.nix b/pkgs/applications/science/biology/raxml/default.nix index 5c7353af931..a77505c1b3f 100644 --- a/pkgs/applications/science/biology/raxml/default.nix +++ b/pkgs/applications/science/biology/raxml/default.nix @@ -15,7 +15,7 @@ stdenv.mkDerivation rec { sha256 = "1jqjzhch0rips0vp04prvb8vmc20c5pdmsqn8knadcf91yy859fh"; }; - buildInputs = if mpi then [ pkgs.openmpi ] else []; + buildInputs = stdenv.lib.optionals mpi [ pkgs.openmpi ]; # TODO darwin, AVX and AVX2 makefile targets buildPhase = if mpi then ''