oh-my-zsh: cleanup

- use fetchFromGitHub instead of fetchgit
 - indent the `installPhase` properly
 - remove unused `pathsToLink`
 - don't hardcode `phases` to allow patching
 - don't copy from $src, but . to allow patching

pkgs/shells/zsh/oh-my-zsh/default.nix

@@ -1,28 +1,26 @@
 # This script was inspired by the ArchLinux User Repository package:
 #
 #   https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=oh-my-zsh-git
-{ stdenv, fetchgit }:
+{ stdenv, fetchFromGitHub }:
 
 stdenv.mkDerivation rec {
   version = "2020-08-24";
   pname = "oh-my-zsh";
-  rev = "cfb86cd08d3b24fd4b59d0d35b3af1f589c891fa";
 
-  src = fetchgit { inherit rev;
+  src = fetchFromGitHub {
-    url = "https://github.com/ohmyzsh/ohmyzsh";
+    owner = "ohmyzsh";
+    repo = "ohmyzsh";
+    rev = "cfb86cd08d3b24fd4b59d0d35b3af1f589c891fa";
     sha256 = "0af37smv0bqw37bng2halzgszf8y3m2sxahdff54m16asm0py2cr";
   };
 
-  pathsToLink = [ "/share/oh-my-zsh" ];
-
-  phases = "installPhase";
 
   installPhase = ''
     outdir=$out/share/oh-my-zsh
     template=templates/zshrc.zsh-template
 
     mkdir -p $outdir
-  cp -r $src/* $outdir
+    cp -r * $outdir
     cd $outdir
 
     rm LICENSE.txt