From 9117f2a7d9480ce9b8b5e07b23efd2ea57e97aca Mon Sep 17 00:00:00 2001 From: Kim Lindberger Date: Fri, 3 Sep 2021 13:23:00 +0200 Subject: [PATCH 1/3] gitaly: Fix gitaly-git2go binary name (#136569) https://gitlab.com/gitlab-org/gitaly/-/commit/e7f8fe4f6759669c24b2fd216beaab4a477c5b3d changed the binary name to always end with its module version. This makes sure gitaly's internal version references are set to the package version and renames the binary, postfixing it with the package version. (cherry picked from commit d14e9188d1cd88f1b530bf860638c2de27486a6d) --- .../version-management/gitlab/gitaly/default.nix | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/pkgs/applications/version-management/gitlab/gitaly/default.nix b/pkgs/applications/version-management/gitlab/gitaly/default.nix index ec4d02a87fd..21dc5a95e87 100644 --- a/pkgs/applications/version-management/gitlab/gitaly/default.nix +++ b/pkgs/applications/version-management/gitlab/gitaly/default.nix @@ -10,9 +10,13 @@ let copyGemFiles = true; gemdir = ./.; }; -in buildGoModule rec { version = "14.2.1"; + gitaly_package = "gitlab.com/gitlab-org/gitaly/v${lib.versions.major version}"; +in + +buildGoModule { pname = "gitaly"; + inherit version; src = fetchFromGitLab { owner = "gitlab-org"; @@ -27,6 +31,10 @@ in buildGoModule rec { inherit rubyEnv; }; + buildFlagsArray = [ + "-ldflags= -X ${gitaly_package}/internal/version.version=${version} -X ${gitaly_package}/internal/version.moduleVersion=${version}" + ]; + buildFlags = [ "-tags=static,system_libgit2" ]; nativeBuildInputs = [ pkg-config ]; buildInputs = [ rubyEnv.wrappedRuby libgit2 openssl zlib pcre http-parser ]; @@ -35,6 +43,7 @@ in buildGoModule rec { postInstall = '' mkdir -p $ruby cp -rv $src/ruby/{bin,lib,proto,git-hooks} $ruby + mv $out/bin/gitaly-git2go $out/bin/gitaly-git2go-${version} ''; outputs = [ "out" "ruby" ]; From 3adca1abf65b49edf5b4b35133584d1925019dc1 Mon Sep 17 00:00:00 2001 From: Artturin Date: Thu, 2 Sep 2021 17:02:16 +0300 Subject: [PATCH 2/3] nixos/pipewire: use absolute path for jack libs (cherry picked from commit 756e60344fd83427148d8acf416c63573404a2e9) --- nixos/modules/services/desktops/pipewire/pipewire.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nixos/modules/services/desktops/pipewire/pipewire.nix b/nixos/modules/services/desktops/pipewire/pipewire.nix index dbd6c5d87e1..bc75aa2717a 100644 --- a/nixos/modules/services/desktops/pipewire/pipewire.nix +++ b/nixos/modules/services/desktops/pipewire/pipewire.nix @@ -194,7 +194,7 @@ in { }; environment.sessionVariables.LD_LIBRARY_PATH = - lib.optional cfg.jack.enable "/run/current-system/sw/lib/pipewire"; + lib.optional cfg.jack.enable "${cfg.package.jack}/lib"; # https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/464#note_723554 systemd.user.services.pipewire.environment."PIPEWIRE_LINK_PASSIVE" = "1"; From e67b69d9a21459b15b614e77cfb8016e7626ac5e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Na=C3=AFm=20Favier?= Date: Fri, 3 Sep 2021 13:58:51 +0200 Subject: [PATCH 3/3] vscode,vscodium: fix moving files to the trash Put gio in PATH so that VSCode is able to move files to the trash. (cherry picked from commit a75326417df32c0354e3244a9461700d214eab82) --- pkgs/applications/editors/vscode/generic.nix | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/pkgs/applications/editors/vscode/generic.nix b/pkgs/applications/editors/vscode/generic.nix index 2d8f639a0c6..5a00b83b023 100644 --- a/pkgs/applications/editors/vscode/generic.nix +++ b/pkgs/applications/editors/vscode/generic.nix @@ -1,7 +1,7 @@ { stdenv, lib, makeDesktopItem , unzip, libsecret, libXScrnSaver, libxshmfence, wrapGAppsHook , gtk2, atomEnv, at-spi2-atk, autoPatchelfHook -, systemd, fontconfig, libdbusmenu, buildFHSUserEnvBubblewrap +, systemd, fontconfig, libdbusmenu, glib, buildFHSUserEnvBubblewrap , writeShellScriptBin # Populate passthru.tests @@ -98,6 +98,13 @@ let runHook postInstall ''; + preFixup = '' + gappsWrapperArgs+=( + # Add gio to PATH so that moving files to the trash works when not using a desktop environment + --prefix PATH : ${glib.bin}/bin + ) + ''; + inherit meta; };