From 1d0225adc0e17baec4292855c6c34b769d3e3d3c Mon Sep 17 00:00:00 2001 From: Andreas Rammhold Date: Mon, 30 Nov 2020 10:09:05 +0100 Subject: [PATCH 1/3] firefox: move the no-buildconfig-ffx76 patch into common This patch has been used on all our flavors for some time now. We can just move it to the common expression. --- pkgs/applications/networking/browsers/firefox/common.nix | 1 + .../applications/networking/browsers/firefox/packages.nix | 8 -------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/pkgs/applications/networking/browsers/firefox/common.nix b/pkgs/applications/networking/browsers/firefox/common.nix index 988f47f3bfb..1fbfdc2a7da 100644 --- a/pkgs/applications/networking/browsers/firefox/common.nix +++ b/pkgs/applications/networking/browsers/firefox/common.nix @@ -118,6 +118,7 @@ buildStdenv.mkDerivation ({ patches = [ ./env_var_for_system_dir.patch + ./no-buildconfig-ffx76.patch ] ++ # there are two flavors of pipewire support diff --git a/pkgs/applications/networking/browsers/firefox/packages.nix b/pkgs/applications/networking/browsers/firefox/packages.nix index 352e7bac5e9..ef6398ea955 100644 --- a/pkgs/applications/networking/browsers/firefox/packages.nix +++ b/pkgs/applications/networking/browsers/firefox/packages.nix @@ -13,10 +13,6 @@ rec { sha512 = "3va5a9471677jfzkhqp8xkba45n0bcpphbabhqbcbnps6p85m3y98pl5jy9q7cpq3a6gxc4ax7bp90yz2nfvfq7i64iz397xpprri2a"; }; - patches = [ - ./no-buildconfig-ffx76.patch - ]; - meta = { description = "A web browser built from Firefox source tree"; homepage = "http://www.mozilla.com/en-US/firefox/"; @@ -41,10 +37,6 @@ rec { sha512 = "20h53cn7p4dds1yfm166iwbjdmw4fkv5pfk4z0pni6x8ddjvg19imzs6ggmpnfhaji8mnlknm7xp5j7x9vi24awvdxdds5n88rh25hd"; }; - patches = [ - ./no-buildconfig-ffx76.patch - ]; - meta = { description = "A web browser built from Firefox Extended Support Release source tree"; homepage = "http://www.mozilla.com/en-US/firefox/"; From cdff2a832cc4345e97081595cf8b771f1601b3a2 Mon Sep 17 00:00:00 2001 From: Andreas Rammhold Date: Mon, 30 Nov 2020 10:24:46 +0100 Subject: [PATCH 2/3] firefox: add aarch64 SIMD patch This patch fixes compilation on aarch64 that broke somewhere between the upgrade to the lateste rustc and the firefox 82 to 83 upgrade. The patch has been submitted upstream and can probably be removed on the next version bump. --- .../networking/browsers/firefox/packages.nix | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/pkgs/applications/networking/browsers/firefox/packages.nix b/pkgs/applications/networking/browsers/firefox/packages.nix index ef6398ea955..b8590739dac 100644 --- a/pkgs/applications/networking/browsers/firefox/packages.nix +++ b/pkgs/applications/networking/browsers/firefox/packages.nix @@ -1,4 +1,4 @@ -{ config, stdenv, lib, callPackage, fetchurl, nss_3_44 }: +{ config, stdenv, lib, callPackage, fetchurl, fetchpatch, nss_3_44 }: let common = opts: callPackage (import ./common.nix opts) {}; @@ -13,6 +13,17 @@ rec { sha512 = "3va5a9471677jfzkhqp8xkba45n0bcpphbabhqbcbnps6p85m3y98pl5jy9q7cpq3a6gxc4ax7bp90yz2nfvfq7i64iz397xpprri2a"; }; + patches = [ + # Fix compilation on aarch64 with newer rust version + # See https://bugzilla.mozilla.org/show_bug.cgi?id=1677690 + # and https://bugzilla.redhat.com/show_bug.cgi?id=1897675 + (fetchpatch { + name = "aarch64-simd-bgz-1677690.patch"; + url = "https://github.com/mozilla/gecko-dev/commit/71597faac0fde4f608a60dd610d0cefac4972cc3.patch"; + sha256 = "1f61nsgbv2c2ylgjs7wdahxrrlgc19gjy5nzs870zr1g832ybwin"; + }) + ]; + meta = { description = "A web browser built from Firefox source tree"; homepage = "http://www.mozilla.com/en-US/firefox/"; From afcbecc1446a86e282d5a5fe68ac3af864b1fa72 Mon Sep 17 00:00:00 2001 From: Andreas Rammhold Date: Mon, 30 Nov 2020 10:26:45 +0100 Subject: [PATCH 3/3] firefox: remove unused "imports" These haven't been used in some time and there is no point in keeping them around. They just clutter the file right now. --- pkgs/applications/networking/browsers/firefox/packages.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/networking/browsers/firefox/packages.nix b/pkgs/applications/networking/browsers/firefox/packages.nix index b8590739dac..d31a1a0e54c 100644 --- a/pkgs/applications/networking/browsers/firefox/packages.nix +++ b/pkgs/applications/networking/browsers/firefox/packages.nix @@ -1,4 +1,4 @@ -{ config, stdenv, lib, callPackage, fetchurl, fetchpatch, nss_3_44 }: +{ stdenv, lib, callPackage, fetchurl, fetchpatch }: let common = opts: callPackage (import ./common.nix opts) {};