From f49002cd26fc582bde059a59ad07e7743ad2f946 Mon Sep 17 00:00:00 2001 From: nyanloutre Date: Sat, 30 Nov 2019 13:20:38 +0100 Subject: [PATCH 1/2] libappindicator-gtk2: add missing automake step --- pkgs/development/libraries/libappindicator/default.nix | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkgs/development/libraries/libappindicator/default.nix b/pkgs/development/libraries/libappindicator/default.nix index 7f3a2678da5..0d969c318ec 100644 --- a/pkgs/development/libraries/libappindicator/default.nix +++ b/pkgs/development/libraries/libappindicator/default.nix @@ -1,7 +1,7 @@ # TODO: Resolve the issues with the Mono bindings. { stdenv, fetchurl, fetchpatch, lib, file -, pkgconfig, autoconf +, pkgconfig, autoreconfHook , glib, dbus-glib, gtkVersion ? "3" , gtk2 ? null, libindicator-gtk2 ? null, libdbusmenu-gtk2 ? null , gtk3 ? null, libindicator-gtk3 ? null, libdbusmenu-gtk3 ? null @@ -24,7 +24,7 @@ stdenv.mkDerivation rec { sha256 = "17xlqd60v0zllrxp8bgq3k5a1jkj0svkqn8rzllcyjh8k0gpr46m"; }; - nativeBuildInputs = [ pkgconfig autoconf vala gobject-introspection ]; + nativeBuildInputs = [ pkgconfig autoreconfHook vala gobject-introspection ]; propagatedBuildInputs = if gtkVersion == "2" @@ -47,7 +47,6 @@ stdenv.mkDerivation rec { ]; postPatch = '' - autoconf for f in {configure,ltmain.sh,m4/libtool.m4}; do substituteInPlace $f \ --replace /usr/bin/file ${file}/bin/file From 573ab436a4e8e17b0561b999b5860df0ed87504a Mon Sep 17 00:00:00 2001 From: nyanloutre Date: Sat, 30 Nov 2019 17:39:09 +0100 Subject: [PATCH 2/2] libappindicator-gtk2: remove obsolete substitutions --- .../libraries/libappindicator/default.nix | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/pkgs/development/libraries/libappindicator/default.nix b/pkgs/development/libraries/libappindicator/default.nix index 0d969c318ec..e9fccaf28ab 100644 --- a/pkgs/development/libraries/libappindicator/default.nix +++ b/pkgs/development/libraries/libappindicator/default.nix @@ -1,6 +1,6 @@ # TODO: Resolve the issues with the Mono bindings. -{ stdenv, fetchurl, fetchpatch, lib, file +{ stdenv, fetchurl, fetchpatch, lib , pkgconfig, autoreconfHook , glib, dbus-glib, gtkVersion ? "3" , gtk2 ? null, libindicator-gtk2 ? null, libdbusmenu-gtk2 ? null @@ -46,13 +46,6 @@ stdenv.mkDerivation rec { }) ]; - postPatch = '' - for f in {configure,ltmain.sh,m4/libtool.m4}; do - substituteInPlace $f \ - --replace /usr/bin/file ${file}/bin/file - done - ''; - configureFlags = [ "CFLAGS=-Wno-error" "--sysconfdir=/etc" @@ -60,11 +53,6 @@ stdenv.mkDerivation rec { "--with-gtk=${gtkVersion}" ]; - postConfigure = '' - substituteInPlace configure \ - --replace /usr/bin/file ${file}/bin/file - ''; - doCheck = false; # generates shebangs in check phase, too lazy to fix installFlags = [