From e5c3614d52b882d348526722edf3770a8a709864 Mon Sep 17 00:00:00 2001 From: Peter Simons Date: Mon, 1 Apr 2013 14:06:56 +0200 Subject: [PATCH] pkgs/build-support/cabal: fix spelling of the --extra-{include,lib}-dirs options to Cabal It's quite amazing that we've managed to pass incorrectly spelled command line flags to Cabal for ages without ever noticing. :-) The search path options --extra-{include,lib}-dirs are usually unnecessary, because the build environment is set up such that gcc and ld find those headers and libraries automatically, i.e. without needing extra flags. The bubble burst on MacOS X, though, where the build of haskell-text-icu couldn't find the icu library without manually setting DYLD_LIBRARY_PATH in that build. Fortunately, cabal takes care of that issue if a correctly spelled --extra-lib-dirs flag is passed. --- pkgs/build-support/cabal/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/build-support/cabal/default.nix b/pkgs/build-support/cabal/default.nix index dd1c2a76d19..4466b7b19b8 100644 --- a/pkgs/build-support/cabal/default.nix +++ b/pkgs/build-support/cabal/default.nix @@ -115,11 +115,11 @@ continue; fi if [ -d "$p/include" ]; then - extraConfigureFlags+=" --extra-include-dir=$p/include" + extraConfigureFlags+=" --extra-include-dirs=$p/include" fi for d in lib{,64}; do if [ -d "$p/$d" ]; then - extraConfigureFlags+=" --extra-lib-dir=$p/$d" + extraConfigureFlags+=" --extra-lib-dirs=$p/$d" fi done done