public
/
nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

llvmPackages: Fix default version calculation 

Add a comment with explanation, which I should have done all along.
This commit is contained in:
John Ericson 2021-05-13 05:24:55 +00:00
parent f030f859b9
commit e3a1c149d2
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkgs/top-level/all-packages.nix
View File

@ -11198,6 +11198,8 @@ in
llvm_5 = llvmPackages_5.llvm; llvm_5 = llvmPackages_5.llvm;
llvmPackages = let llvmPackages = let
# This returns the minimum suported version for the platform. The
# assumption is that or any later version is good.
choose = platform: choose = platform:
/**/ if platform.isDarwin then "7" /**/ if platform.isDarwin then "7"
else if platform.isFreeBSD then "7" else if platform.isFreeBSD then "7"
@ -11205,7 +11207,10 @@ in
else if platform.isLinux then "7" else if platform.isLinux then "7"
else if platform.isWasm then "8" else if platform.isWasm then "8"
else "latest"; else "latest";
minSupported = lib.min (choose stdenv.hostPlatform) (choose stdenv.targetPlatform); # We take the "max of the mins". Why? Since those are lower bounds of the
# supported version set, this is like intersecting those sets and then
# taking the min bound of that.
minSupported = lib.max (choose stdenv.hostPlatform) (choose stdenv.targetPlatform);
in pkgs.${"llvmPackages_${minSupported}"}; in pkgs.${"llvmPackages_${minSupported}"};
llvmPackages_5 = recurseIntoAttrs (callPackage ../development/compilers/llvm/5 { llvmPackages_5 = recurseIntoAttrs (callPackage ../development/compilers/llvm/5 {