public
/
nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

arpack: cosmetic changes 

Don't use `with stdenv.lib` at the top of the expression, per:
https://nix.dev/anti-patterns/language.html#with-attrset-expression

Use rec and version inside `mkDerivation`, like almost any other
derivation.
This commit is contained in:
Doron Behar 2020-09-23 00:52:45 +03:00
parent 06b27898a4
commit e0d947c79c
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkgs/development/libraries/science/math/arpack/default.nix
View File

@ -1,14 +1,9 @@
{ stdenv, fetchFromGitHub, cmake { stdenv, fetchFromGitHub, cmake
, gfortran, blas, lapack, eigen }: , gfortran, blas, lapack, eigen }:
with stdenv.lib; stdenv.mkDerivation rec {
let
version = "3.7.0";
in
stdenv.mkDerivation {
pname = "arpack"; pname = "arpack";
inherit version; version = "3.7.0";
src = fetchFromGitHub { src = fetchFromGitHub {
owner = "opencollab"; owner = "opencollab";
@ -27,7 +22,7 @@ stdenv.mkDerivation {
cmakeFlags = [ cmakeFlags = [
"-DBUILD_SHARED_LIBS=ON" "-DBUILD_SHARED_LIBS=ON"
"-DINTERFACE64=${optionalString blas.isILP64 "1"}" "-DINTERFACE64=${stdenv.lib.optionalString blas.isILP64 "1"}"
]; ];
preCheck = if stdenv.isDarwin then '' preCheck = if stdenv.isDarwin then ''