public
/
nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib: fix functionArgs for functors 

`functionArgs` should give valid results on
functions that have been identified with `lib.isFunction`
instead of erroring out.

(cherry picked from commit cf8e219b7e3c8933d6301175f2611990c5281ae9)
This commit is contained in:
David Arnold 2021-07-23 14:10:31 -05:00 committed by github-actions[bot]
parent 2bd2119bf3
commit e07870c95e
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/tests/misc.nix
View File

@ -132,6 +132,16 @@ runTests {
expected = [ 1 1 0 ]; expected = [ 1 1 0 ];
}; };
testFunctionArgsFunctor = {
expr = functionArgs { __functor = self: { a, b }: null; };
expected = { a = false; b = false; };
};
testFunctionArgsSetFunctionArgs = {
expr = functionArgs (setFunctionArgs (args: args.x) { x = false; });
expected = { x = false; };
};
# STRINGS # STRINGS
testConcatMapStrings = { testConcatMapStrings = {

5
lib/trivial.nix
View File

@ -334,7 +334,10 @@ rec {
has the same return type and semantics as builtins.functionArgs. has the same return type and semantics as builtins.functionArgs.
setFunctionArgs : (a → b) → Map String Bool. setFunctionArgs : (a → b) → Map String Bool.
*/ */
functionArgs = f: f.__functionArgs or (builtins.functionArgs f); functionArgs = f:
if f ? __functor
then f.__functionArgs or (lib.functionArgs (f.__functor f))
else builtins.functionArgs f;
/* Check whether something is a function or something /* Check whether something is a function or something
annotated with function args. annotated with function args.