From dd63561bcbe5f7b86063c7c6e80fca5af487d801 Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Wed, 17 Feb 2021 17:37:23 +0100 Subject: [PATCH] Remove ripgrep test VM tests are expensive (and prone to random failures) so they should only be used for things that can only be tested in a VM, not for things that could be tested in a regular checkPhase or derivation. --- nixos/tests/all-tests.nix | 1 - nixos/tests/ripgrep.nix | 13 ------------- 2 files changed, 14 deletions(-) delete mode 100644 nixos/tests/ripgrep.nix diff --git a/nixos/tests/all-tests.nix b/nixos/tests/all-tests.nix index 444580bc0be..ac0d25ac2ee 100644 --- a/nixos/tests/all-tests.nix +++ b/nixos/tests/all-tests.nix @@ -332,7 +332,6 @@ in redis = handleTest ./redis.nix {}; redmine = handleTest ./redmine.nix {}; restic = handleTest ./restic.nix {}; - ripgrep = handleTest ./ripgrep.nix {}; robustirc-bridge = handleTest ./robustirc-bridge.nix {}; roundcube = handleTest ./roundcube.nix {}; rspamd = handleTest ./rspamd.nix {}; diff --git a/nixos/tests/ripgrep.nix b/nixos/tests/ripgrep.nix deleted file mode 100644 index 3ff3bf4be15..00000000000 --- a/nixos/tests/ripgrep.nix +++ /dev/null @@ -1,13 +0,0 @@ -import ./make-test-python.nix ({ pkgs, ... }: { - name = "ripgrep"; - meta = with pkgs.lib.maintainers; { maintainers = [ nequissimus ]; }; - - nodes.ripgrep = { pkgs, ... }: { environment.systemPackages = [ pkgs.ripgrep ]; }; - - testScript = '' - ripgrep.succeed('echo "abc\nbcd\ncde" > /tmp/foo') - assert "bcd" in ripgrep.succeed("rg -N 'bcd' /tmp/foo") - assert "bcd\ncde" in ripgrep.succeed("rg -N 'cd' /tmp/foo") - assert "ripgrep ${pkgs.ripgrep.version}" in ripgrep.succeed("rg --version | head -1") - ''; -})