treewide: use runtimeShell instead of stdenv.shell whenever possible

Whenever we create scripts that are installed to $out, we must use runtimeShell
in order to get the shell that can be executed on the machine we create the
package for. This is relevant for cross-compiling. The only use case for
stdenv.shell are scripts that are executed as part of the build system.
Usages in checkPhase are borderline however to decrease the likelyhood
of people copying the wrong examples, I decided to use runtimeShell as well.
This commit is contained in:
Jörg Thalheim
2019-02-26 11:45:54 +00:00
parent 1233c8d9e9
commit dadc7eb329
131 changed files with 326 additions and 294 deletions

View File

@@ -5,7 +5,7 @@
# for token storage, except that it would make the Nix package inconsistent with
# upstream and other distributions.
{ stdenv, lib, writeShellScriptBin, fetchFromGitHub, curl, jq }:
{ stdenv, lib, writeShellScriptBin, fetchFromGitHub, curl, jq, runtimeShell }:
stdenv.mkDerivation rec {
name = "slack-cli-${version}";
@@ -25,7 +25,7 @@ stdenv.mkDerivation rec {
cp src/slack "$out/bin/.slack-wrapped"
cat <<-WRAPPER > "$out/bin/slack"
#!${stdenv.shell}
#!${runtimeShell}
[ "\$1" = "init" -a -z "\$SLACK_CLI_TOKEN" ] && cat <<-'MESSAGE' >&2
WARNING: slack-cli must be configured using the SLACK_CLI_TOKEN
environment variable. Using \`slack init\` will not work because it tries