From 3d8260fcf66981f63d6c6581a4183801142cf824 Mon Sep 17 00:00:00 2001 From: SLNOS Date: Wed, 15 Nov 2017 00:00:00 +0000 Subject: [PATCH 1/3] Revert a part of "firefox: 56.0.2 -> 57.0" This reverts a part of commit 559433d0db3979f77befe73ad5c65b8500277629. The problem with removing those options completely is that without them tor-browser's config differs from the official config (which may or may not be a problem for fingerprinting). --- pkgs/applications/networking/browsers/firefox/common.nix | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkgs/applications/networking/browsers/firefox/common.nix b/pkgs/applications/networking/browsers/firefox/common.nix index ccf762afbec..b8f57eb2edb 100644 --- a/pkgs/applications/networking/browsers/firefox/common.nix +++ b/pkgs/applications/networking/browsers/firefox/common.nix @@ -29,9 +29,11 @@ # Set to `privacySupport` or `false`. , webrtcSupport ? !privacySupport -, googleAPISupport ? !privacySupport +, geolocationSupport ? !privacySupport +, googleAPISupport ? geolocationSupport , crashreporterSupport ? false +, safeBrowsingSupport ? false , drmSupport ? false ## other @@ -159,8 +161,10 @@ stdenv.mkDerivation (rec { ++ flag gssSupport "negotiateauth" ++ lib.optional (!ffmpegSupport) "--disable-gstreamer" ++ flag webrtcSupport "webrtc" + ++ flag geolocationSupport "mozril-geoloc" ++ lib.optional googleAPISupport "--with-google-api-keyfile=ga" ++ flag crashreporterSupport "crashreporter" + ++ flag safeBrowsingSupport "safe-browsing" ++ lib.optional drmSupport "--enable-eme=widevine" ++ (if debugBuild then [ "--enable-debug" "--enable-profiling" ] From d838fbe2b3a3d87ed3ce96c9bd23a3493bf7858b Mon Sep 17 00:00:00 2001 From: SLNOS Date: Wed, 15 Nov 2017 00:00:00 +0000 Subject: [PATCH 2/3] firefoxPackages: move old firefox flags under isTorBrowserLike --- pkgs/applications/networking/browsers/firefox/common.nix | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkgs/applications/networking/browsers/firefox/common.nix b/pkgs/applications/networking/browsers/firefox/common.nix index b8f57eb2edb..e0f2844bd53 100644 --- a/pkgs/applications/networking/browsers/firefox/common.nix +++ b/pkgs/applications/networking/browsers/firefox/common.nix @@ -143,7 +143,7 @@ stdenv.mkDerivation (rec { ] # and wants these - ++ lib.optionals isTorBrowserLike [ + ++ lib.optionals isTorBrowserLike ([ "--with-tor-browser-version=${version}" "--enable-signmar" "--enable-verify-mar" @@ -153,7 +153,9 @@ stdenv.mkDerivation (rec { # possibilities on other platforms. # Lets save some space instead. "--with-system-nspr" - ] + ] ++ flag geolocationSupport "mozril-geoloc" + ++ flag safeBrowsingSupport "safe-browsing" + ) ++ flag alsaSupport "alsa" ++ flag pulseaudioSupport "pulseaudio" @@ -161,10 +163,8 @@ stdenv.mkDerivation (rec { ++ flag gssSupport "negotiateauth" ++ lib.optional (!ffmpegSupport) "--disable-gstreamer" ++ flag webrtcSupport "webrtc" - ++ flag geolocationSupport "mozril-geoloc" ++ lib.optional googleAPISupport "--with-google-api-keyfile=ga" ++ flag crashreporterSupport "crashreporter" - ++ flag safeBrowsingSupport "safe-browsing" ++ lib.optional drmSupport "--enable-eme=widevine" ++ (if debugBuild then [ "--enable-debug" "--enable-profiling" ] From d0eed985d24be20d8537d8517065d89d2fabd469 Mon Sep 17 00:00:00 2001 From: SLNOS Date: Wed, 1 Nov 2017 00:00:00 +0000 Subject: [PATCH 3/3] firefoxPackages: tor-browser: 52.3.0esr-7.0.1 -> 52.5.0esr-7.0-1 fixes that file:// vuln --- pkgs/applications/networking/browsers/firefox/packages.nix | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pkgs/applications/networking/browsers/firefox/packages.nix b/pkgs/applications/networking/browsers/firefox/packages.nix index c08e7aca285..8652e406d4d 100644 --- a/pkgs/applications/networking/browsers/firefox/packages.nix +++ b/pkgs/applications/networking/browsers/firefox/packages.nix @@ -109,7 +109,7 @@ in rec { src = fetchFromGitHub { owner = "SLNOS"; repo = "tor-browser"; - # branch "tor-browser-45.8.0esr-6.5-2" + # branch "tor-browser-45.8.0esr-6.5-2-slnos" rev = "e4140ea01b9906934f0347e95f860cec207ea824"; sha256 = "0a1qk3a9a3xxrl56bp4zbknbchv5x17k1w5kgcf4j3vklcv6av60"; }; @@ -128,8 +128,9 @@ in rec { src = fetchFromGitHub { owner = "SLNOS"; repo = "tor-browser"; - rev = "tor-browser-52.3.0esr-7.0-1-slnos"; - sha256 = "0szbf8gjbl4dnrb4igy4mq5858i1y6ki4skhdw63iqqdd8w9v4yv"; + # branch "tor-browser-52.5.0esr-7.0-1-slnos"; + rev = "830ff8d622ef20345d83f386174f790b0fc2440d"; + sha256 = "169mjkr0bp80yv9nzza7kay7y2k03lpnx71h4ybcv9ygxgzdgax5"; }; patches =