From d85fabd68cb0477f7bda4af8a528e27ed7914932 Mon Sep 17 00:00:00 2001
From: aszlig <aszlig@redmoonstudios.org>
Date: Mon, 15 Dec 2014 19:12:58 +0100
Subject: [PATCH] nixos/virtualbox/hostonlyif: Fix writing to /root.

Creates unnecessary cruft in the root users home directory, which we
really don't need. Except the log, but therefore we now cat the log to
stderr and the private temporary directory is cleaned up afterwards.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
---
 nixos/modules/programs/virtualbox-host.nix | 3 +++
 nixos/tests/virtualbox.nix                 | 1 +
 2 files changed, 4 insertions(+)

diff --git a/nixos/modules/programs/virtualbox-host.nix b/nixos/modules/programs/virtualbox-host.nix
index f4c6b7587bd..dd6fbad4868 100644
--- a/nixos/modules/programs/virtualbox-host.nix
+++ b/nixos/modules/programs/virtualbox-host.nix
@@ -97,10 +97,13 @@ in
         path = [ virtualbox ];
         serviceConfig.RemainAfterExit = true;
         serviceConfig.Type = "oneshot";
+        serviceConfig.PrivateTmp = true;
+        environment.VBOX_USER_HOME = "/tmp";
         script =
           ''
             if ! [ -e /sys/class/net/vboxnet0 ]; then
               VBoxManage hostonlyif create
+              cat /tmp/VBoxSVC.log >&2
             fi
           '';
         postStop =
diff --git a/nixos/tests/virtualbox.nix b/nixos/tests/virtualbox.nix
index f23f50a2f1c..1c4765e15f1 100644
--- a/nixos/tests/virtualbox.nix
+++ b/nixos/tests/virtualbox.nix
@@ -348,6 +348,7 @@ in {
 
     subtest "privilege-escalation", sub {
       $machine->fail("test -e '/root/VirtualBox VMs'");
+      $machine->fail("test -e '/root/.config/VirtualBox'");
       $machine->succeed("test -e '/home/alice/VirtualBox VMs'");
     };