From 493c357720bceb8f7eb21c130b5d955c2c4b6fe6 Mon Sep 17 00:00:00 2001 From: Profpatsch Date: Tue, 18 Feb 2020 19:53:18 +0100 Subject: [PATCH 1/2] pkgs/build-support/writers: use `runCommandLocal` for scripts MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If we just want to write a non-compiled script (e.g. writeDash), it’s usually a lot faster just doing it locally. That’s what `runCommandLocal` was introduced for, so let’s use it in `writers`. --- pkgs/build-support/writers/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/build-support/writers/default.nix b/pkgs/build-support/writers/default.nix index b90c6490e4a..af492d80db0 100644 --- a/pkgs/build-support/writers/default.nix +++ b/pkgs/build-support/writers/default.nix @@ -15,7 +15,7 @@ rec { name = last (builtins.split "/" nameOrPath); in - pkgs.runCommand name (if (types.str.check content) then { + pkgs.runCommandLocal name (if (types.str.check content) then { inherit content interpreter; passAsFile = [ "content" ]; } else { @@ -192,7 +192,7 @@ rec { {id="";for(i=idx;i Date: Tue, 18 Feb 2020 19:59:48 +0100 Subject: [PATCH 2/2] CODEOWNERS: add lassulus and Profpatsch to build-support/writers --- .github/CODEOWNERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 3392fa5dab9..27f4da36f2d 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -31,6 +31,9 @@ /pkgs/build-support/bintools-wrapper @Ericson2314 @orivej /pkgs/build-support/setup-hooks @Ericson2314 +# Nixpkgs build-support +/pkgs/build-support/writers @lassulus @Profpatsch + # NixOS Internals /nixos/default.nix @nbp @infinisil /nixos/lib/from-env.nix @nbp @infinisil