Merge pull request #61147 from c0bw3b/pkg/memtest

memtest86+: update / remove legacy memtest86

pkgs/tools/misc/memtest86+/default.nix

@@ -1,23 +1,15 @@
 { stdenv, fetchgit }:
 
 stdenv.mkDerivation rec {
-  name = "memtest86+-5.01+coreboot-20180113";
+  pname = "memtest86+";
+  version = "5.01-coreboot-002";
 
   src = fetchgit {
-    url = "https://review.coreboot.org/memtest86plus";
+    url = "https://review.coreboot.org/memtest86plus.git";
-    rev = "5ca4eb9544e51254254d09ae6e70f93403469ec3";
+    rev = "v002";
-    sha256 = "08m4rjr0chhhb1whgggknz926zv9hm8bisnxqp8lffqiwhb55rgk";
+    sha256 = "0cwx20yja24bfknqh1rjb5rl2c0kwnppzsisg1dibbak0l8mxchk";
   };
 
-  preBuild = ''
-    # Really dirty hack to get Memtest to build without needing a Glibc
-    # with 32-bit libraries and headers.
-    if test "$system" = x86_64-linux; then
-        mkdir gnu
-        touch gnu/stubs-32.h
-    fi
-  '';
-
   NIX_CFLAGS_COMPILE = "-I. -std=gnu90";
 
   hardeningDisable = [ "all" ];
@@ -27,13 +19,11 @@ stdenv.mkDerivation rec {
   doCheck = false; # fails
 
   installPhase = ''
-    mkdir -p $out
+    install -Dm0444 -t $out/ memtest.bin
-    chmod -x memtest.bin
-    cp memtest.bin $out/
   '';
 
   meta = {
-    homepage = http://www.memtest.org/;
+    homepage = "http://www.memtest.org/";
     description = "A tool to detect memory errors";
     license = stdenv.lib.licenses.gpl2;
     platforms = [ "x86_64-linux" "i686-linux" ];

pkgs/tools/misc/memtest86/default.nix

@@ -1,32 +0,0 @@
-{ stdenv, fetchurl }:
-
-stdenv.mkDerivation {
-  name = "memtest86-4.3.6";
-  
-  src = fetchurl {
-    url = https://www.memtest86.com/downloads/memtest86-4.3.6-src.tar.gz;
-    sha256 = "0qbksyl2hmkm12n7zbmf2m2n3q811skhykxx6a9a7y6r7k8y5qmv";
-  };
-
-  preBuild = ''
-    # Really dirty hack to get Memtest to build without needing a Glibc
-    # with 32-bit libraries and headers.
-    if test "$system" = x86_64-linux; then
-        mkdir gnu
-        touch gnu/stubs-32.h
-    fi
-  '';
-
-  NIX_CFLAGS_COMPILE = "-I.";
-  
-  installPhase = ''
-    mkdir -p $out
-    cp memtest.bin $out/
-  '';
-
-  meta = {
-    homepage = http://memtest86.com/;
-    description = "A tool to detect memory errors, to be run from a bootloader";
-    broken = true;
-  };
-}

pkgs/top-level/aliases.nix

@@ -181,6 +181,7 @@ mapAliases ({
   m3d-linux = m33-linux; # added 2016-08-13
   man_db = man-db; # added 2016-05
   manpages = man-pages; # added 2015-12-06
+  memtest86 = memtest86plus; # added 2019-05-08
   midoriWrapper = midori; # added 2015-01
   mlt-qt5 = libsForQt5.mlt;  # added 2015-12-19
   mobile_broadband_provider_info = mobile-broadband-provider-info; # added 2018-02-25

pkgs/top-level/all-packages.nix

@@ -4436,8 +4436,6 @@ in
 
   memtier-benchmark = callPackage ../tools/networking/memtier-benchmark { };
 
-  memtest86 = callPackage ../tools/misc/memtest86 { };
-
   memtest86-efi = callPackage ../tools/misc/memtest86-efi { };
 
   memtest86plus = callPackage ../tools/misc/memtest86+ { };