Python: use pythonPackagesBuildHost instead of pythonForBuild

Follow-up to #104201, related to #105113.
This commit is contained in:
Frederik Rietdijk 2020-11-27 16:24:42 +01:00
parent be36f6f0a0
commit cce2fd547b
4 changed files with 26 additions and 21 deletions

View File

@ -18,8 +18,8 @@
, ucsEncoding ? 4 , ucsEncoding ? 4
# For the Python package set # For the Python package set
, packageOverrides ? (self: super: {}) , packageOverrides ? (self: super: {})
, buildPackages
, pkgsBuildBuild , pkgsBuildBuild
, pkgsBuildHost
, pkgsBuildTarget , pkgsBuildTarget
, pkgsHostHost , pkgsHostHost
, pkgsTargetTarget , pkgsTargetTarget
@ -28,6 +28,7 @@
, passthruFun , passthruFun
, static ? false , static ? false
, enableOptimizations ? (!stdenv.isDarwin) , enableOptimizations ? (!stdenv.isDarwin)
, pythonAttr ? "python${sourceVersion.major}${sourceVersion.minor}"
}: }:
assert x11Support -> tcl != null assert x11Support -> tcl != null
@ -38,9 +39,8 @@ assert x11Support -> tcl != null
with stdenv.lib; with stdenv.lib;
let let
buildPackages = pkgsBuildHost;
pythonAttr = "python${sourceVersion.major}${sourceVersion.minor}"; inherit (passthru) pythonForBuild;
pythonForBuild = buildPackages.${pythonAttr};
passthru = passthruFun rec { passthru = passthruFun rec {
inherit self sourceVersion packageOverrides; inherit self sourceVersion packageOverrides;
@ -49,8 +49,9 @@ let
executable = libPrefix; executable = libPrefix;
pythonVersion = with sourceVersion; "${major}.${minor}"; pythonVersion = with sourceVersion; "${major}.${minor}";
sitePackages = "lib/${libPrefix}/site-packages"; sitePackages = "lib/${libPrefix}/site-packages";
inherit hasDistutilsCxxPatch pythonForBuild; inherit hasDistutilsCxxPatch;
pythonPackagesBuildBuild = pkgsBuildBuild.${pythonAttr}; pythonPackagesBuildBuild = pkgsBuildBuild.${pythonAttr};
pythonPackagesBuildHost = pkgsBuildHost.${pythonAttr};
pythonPackagesBuildTarget = pkgsBuildTarget.${pythonAttr}; pythonPackagesBuildTarget = pkgsBuildTarget.${pythonAttr};
pythonPackagesHostHost = pkgsHostHost.${pythonAttr}; pythonPackagesHostHost = pkgsHostHost.${pythonAttr};
pythonPackagesTargetTarget = pkgsTargetTarget.${pythonAttr} or {}; pythonPackagesTargetTarget = pkgsTargetTarget.${pythonAttr} or {};

View File

@ -19,12 +19,11 @@
, nukeReferences , nukeReferences
# For the Python package set # For the Python package set
, packageOverrides ? (self: super: {}) , packageOverrides ? (self: super: {})
, buildPackages
, pkgsBuildBuild , pkgsBuildBuild
, pkgsBuildHost
, pkgsBuildTarget , pkgsBuildTarget
, pkgsHostHost , pkgsHostHost
, pkgsTargetTarget , pkgsTargetTarget
, pythonForBuild ? buildPackages.${pythonAttr}
, sourceVersion , sourceVersion
, sha256 , sha256
, passthruFun , passthruFun
@ -58,7 +57,8 @@ assert bluezSupport -> bluez != null;
with stdenv.lib; with stdenv.lib;
let let
buildPackages = pkgsBuildHost;
inherit (passthru) pythonForBuild;
passthru = passthruFun rec { passthru = passthruFun rec {
inherit self sourceVersion packageOverrides; inherit self sourceVersion packageOverrides;
@ -67,8 +67,9 @@ let
executable = libPrefix; executable = libPrefix;
pythonVersion = with sourceVersion; "${major}.${minor}"; pythonVersion = with sourceVersion; "${major}.${minor}";
sitePackages = "lib/${libPrefix}/site-packages"; sitePackages = "lib/${libPrefix}/site-packages";
inherit hasDistutilsCxxPatch pythonForBuild; inherit hasDistutilsCxxPatch;
pythonPackagesBuildBuild = pkgsBuildBuild.${pythonAttr}; pythonPackagesBuildBuild = pkgsBuildBuild.${pythonAttr};
pythonPackagesBuildHost = pkgsBuildHost.${pythonAttr};
pythonPackagesBuildTarget = pkgsBuildTarget.${pythonAttr}; pythonPackagesBuildTarget = pkgsBuildTarget.${pythonAttr};
pythonPackagesHostHost = pkgsHostHost.${pythonAttr}; pythonPackagesHostHost = pkgsHostHost.${pythonAttr};
pythonPackagesTargetTarget = pkgsTargetTarget.${pythonAttr} or {}; pythonPackagesTargetTarget = pkgsTargetTarget.${pythonAttr} or {};
@ -95,8 +96,6 @@ let
hasDistutilsCxxPatch = !(stdenv.cc.isGNU or false); hasDistutilsCxxPatch = !(stdenv.cc.isGNU or false);
inherit pythonForBuild;
pythonForBuildInterpreter = if stdenv.hostPlatform == stdenv.buildPlatform then pythonForBuildInterpreter = if stdenv.hostPlatform == stdenv.buildPlatform then
"$out/bin/python" "$out/bin/python"
else pythonForBuild.interpreter; else pythonForBuild.interpreter;

View File

@ -15,7 +15,7 @@ with pkgs;
, sitePackages , sitePackages
, hasDistutilsCxxPatch , hasDistutilsCxxPatch
, pythonPackagesBuildBuild , pythonPackagesBuildBuild
, pythonForBuild # provides pythonPackagesBuildHost , pythonPackagesBuildHost
, pythonPackagesBuildTarget , pythonPackagesBuildTarget
, pythonPackagesHostHost , pythonPackagesHostHost
, self # is pythonPackagesHostTarget , self # is pythonPackagesHostTarget
@ -29,7 +29,7 @@ with pkgs;
}; };
otherSplices = { otherSplices = {
selfBuildBuild = pythonPackagesBuildBuild; selfBuildBuild = pythonPackagesBuildBuild;
selfBuildHost = pythonForBuild.pkgs; selfBuildHost = pythonPackagesBuildHost;
selfBuildTarget = pythonPackagesBuildTarget; selfBuildTarget = pythonPackagesBuildTarget;
selfHostHost = pythonPackagesHostHost; selfHostHost = pythonPackagesHostHost;
selfTargetTarget = pythonPackagesTargetTarget; selfTargetTarget = pythonPackagesTargetTarget;
@ -99,7 +99,8 @@ with pkgs;
inherit sourceVersion; inherit sourceVersion;
pythonAtLeast = lib.versionAtLeast pythonVersion; pythonAtLeast = lib.versionAtLeast pythonVersion;
pythonOlder = lib.versionOlder pythonVersion; pythonOlder = lib.versionOlder pythonVersion;
inherit hasDistutilsCxxPatch pythonForBuild; inherit hasDistutilsCxxPatch;
pythonForBuild = pythonPackagesBuildHost;
tests = callPackage ./tests.nix { tests = callPackage ./tests.nix {
python = self; python = self;
@ -188,7 +189,6 @@ in {
# Minimal versions of Python (built without optional dependencies) # Minimal versions of Python (built without optional dependencies)
python3Minimal = (python38.override { python3Minimal = (python38.override {
self = python3Minimal; self = python3Minimal;
pythonForBuild = pkgs.buildPackages.python3Minimal;
# strip down that python version as much as possible # strip down that python version as much as possible
openssl = null; openssl = null;
readline = null; readline = null;

View File

@ -5,10 +5,16 @@
, python-setup-hook , python-setup-hook
# For the Python package set # For the Python package set
, packageOverrides ? (self: super: {}) , packageOverrides ? (self: super: {})
, pkgsBuildBuild
, pkgsBuildHost
, pkgsBuildTarget
, pkgsHostHost
, pkgsTargetTarget
, sourceVersion , sourceVersion
, pythonVersion , pythonVersion
, sha256 , sha256
, passthruFun , passthruFun
, pythonAttr ? "pypy${stdenv.lib.substring 0 1 pythonVersion}${stdenv.lib.substring 2 3 pythonVersion}"
}: }:
assert zlibSupport -> zlib != null; assert zlibSupport -> zlib != null;
@ -25,12 +31,11 @@ let
sitePackages = "site-packages"; sitePackages = "site-packages";
hasDistutilsCxxPatch = false; hasDistutilsCxxPatch = false;
# No cross-compiling for now. pythonPackagesBuildBuild = pkgsBuildBuild.${pythonAttr};
pythonForBuild = self; pythonPackagesBuildHost = pkgsBuildHost.${pythonAttr};
pythonPackagesBuildBuild = {}; pythonPackagesBuildTarget = pkgsBuildTarget.${pythonAttr};
pythonPackagesBuildTarget = {}; pythonPackagesHostHost = pkgsHostHost.${pythonAttr};
pythonPackagesHostHost = {}; pythonPackagesTargetTarget = pkgsTargetTarget.${pythonAttr} or {};
pythonPackagesTargetTarget = {};
}; };
pname = passthru.executable; pname = passthru.executable;
version = with sourceVersion; "${major}.${minor}.${patch}"; version = with sourceVersion; "${major}.${minor}.${patch}";