sbt-extras: Convert VM test into installCheckPhase

nixos/tests/all-tests.nix

@@ -345,7 +345,6 @@ in
   samba-wsdd = handleTest ./samba-wsdd.nix {};
   sanoid = handleTest ./sanoid.nix {};
   sbt = handleTest ./sbt.nix {};
-  sbt-extras = handleTest ./sbt-extras.nix {};
   sddm = handleTest ./sddm.nix {};
   searx = handleTest ./searx.nix {};
   service-runner = handleTest ./service-runner.nix {};

nixos/tests/sbt-extras.nix

@@ -1,16 +0,0 @@
-import ./make-test-python.nix ({ pkgs, ...} : {
-  name = "sbt-extras";
-  meta = with pkgs.lib.maintainers; {
-    maintainers = [ nequissimus ];
-  };
-
-  machine = { pkgs, ... }:
-    {
-      environment.systemPackages = [ pkgs.sbt-extras ];
-    };
-
-  testScript =
-    ''
-      machine.succeed("(sbt -h)")
-    '';
-})

pkgs/development/tools/build-managers/sbt-extras/default.nix

@@ -1,6 +1,20 @@
-{ lib, stdenv, fetchFromGitHub, which, curl, makeWrapper, jdk, writeScript
+{ lib
-, common-updater-scripts, cacert, git, nixfmt, nix, jq, coreutils, gnused
+, stdenv
-, nixosTests }:
+, fetchFromGitHub
+, which
+, curl
+, makeWrapper
+, jdk
+, writeScript
+, common-updater-scripts
+, cacert
+, git
+, nixfmt
+, nix
+, jq
+, coreutils
+, gnused
+}:
 
 stdenv.mkDerivation rec {
   pname = "sbt-extras";
@@ -28,41 +42,40 @@ stdenv.mkDerivation rec {
     wrapProgram $out/bin/sbt --prefix PATH : ${lib.makeBinPath [ which curl ]}
   '';
 
-  passthru = {
+  doInstallCheck = true;
-    tests = { inherit (nixosTests) sbt-extras; };
+  installCheckPhase = ''
+    $out/bin/sbt -h >/dev/null
+  '';
 
-    updateScript = writeScript "update.sh" ''
+  passthru.updateScript = writeScript "update.sh" ''
-      #!${stdenv.shell}
+     #!${stdenv.shell}
-      set -xo errexit
+     set -xo errexit
-      PATH=${
+     PATH=${
-        lib.makeBinPath [
+       lib.makeBinPath [
-          common-updater-scripts
+         common-updater-scripts
-          curl
+         curl
-          cacert
+         cacert
-          git
+         git
-          nixfmt
+         nixfmt
-          nix
+         nix
-          jq
+         jq
-          coreutils
+         coreutils
-          gnused
+         gnused
-        ]
+       ]
-      }
+     }
-
+    oldVersion="$(nix-instantiate --eval -E "with import ./. {}; lib.getVersion ${pname}" | tr -d '"')"
-      oldVersion="$(nix-instantiate --eval -E "with import ./. {}; lib.getVersion ${pname}" | tr -d '"')"
+     latestSha="$(curl -L -s https://api.github.com/repos/paulp/sbt-extras/commits\?sha\=master\&since\=$oldVersion | jq -r '.[0].sha')"
-      latestSha="$(curl -L -s https://api.github.com/repos/paulp/sbt-extras/commits\?sha\=master\&since\=$oldVersion | jq -r '.[0].sha')"
+    if [ ! "null" = "$latestSha" ]; then
-
+       nixpkgs="$(git rev-parse --show-toplevel)"
-      if [ ! "null" = "$latestSha" ]; then
+       default_nix="$nixpkgs/pkgs/development/tools/build-managers/sbt-extras/default.nix"
-        nixpkgs="$(git rev-parse --show-toplevel)"
+       latestDate="$(curl -L -s https://api.github.com/repos/paulp/sbt-extras/commits/$latestSha | jq '.commit.committer.date' | sed 's|"\(.*\)T.*|\1|g')"
-        default_nix="$nixpkgs/pkgs/development/tools/build-managers/sbt-extras/default.nix"
+       update-source-version ${pname} "$latestSha" --version-key=rev
-        latestDate="$(curl -L -s https://api.github.com/repos/paulp/sbt-extras/commits/$latestSha | jq '.commit.committer.date' | sed 's|"\(.*\)T.*|\1|g')"
+       update-source-version ${pname} "$latestDate" --ignore-same-hash
-        update-source-version ${pname} "$latestSha" --version-key=rev
+       nixfmt "$default_nix"
-        update-source-version ${pname} "$latestDate" --ignore-same-hash
+     else
-        nixfmt "$default_nix"
+       echo "${pname} is already up-to-date"
-      else
+     fi
-        echo "${pname} is already up-to-date"
+  '';
-      fi
-    '';
-  };
 
   meta = {
     description =