From c640f7efd1bbbee7a935b06a28f433918f0036aa Mon Sep 17 00:00:00 2001
From: Corban Raun <corban@raunco.co>
Date: Mon, 25 May 2020 07:46:14 -0600
Subject: [PATCH] _1password: do not strip binary on darwin(OSX) (#88091)

Stripping the binary on OSX causes op(1password) to fail immediately.
Setting dontStrip = true; fixes the issue.
Additionally, adding a very simple installCheck section for testing
purposes.

Co-authored-by: Corban Raun <craun@instructure.com>
---
 pkgs/applications/misc/1password/default.nix | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/pkgs/applications/misc/1password/default.nix b/pkgs/applications/misc/1password/default.nix
index 010e9ae7a50..22cbb0ec4a0 100644
--- a/pkgs/applications/misc/1password/default.nix
+++ b/pkgs/applications/misc/1password/default.nix
@@ -34,8 +34,16 @@ stdenv.mkDerivation rec {
     install -D op $out/bin/op
   '';
 
+  dontStrip = stdenv.isDarwin;
+
   nativeBuildInputs = stdenv.lib.optionals stdenv.isLinux [ autoPatchelfHook ];
 
+  doInstallCheck = true;
+
+  installCheckPhase = ''
+    $out/bin/op --version
+  '';
+
   meta = with stdenv.lib; {
     description  = "1Password command-line tool";
     homepage     = "https://support.1password.com/command-line/";