From e2c6ea72a1587d977186dcad6967b3afccadc945 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Fri, 22 Dec 2017 12:19:26 +0100 Subject: [PATCH 1/4] virtualbox: 5.2.2 -> 5.2.4 --- pkgs/applications/virtualization/virtualbox/default.nix | 9 +++++---- .../virtualbox/guest-additions/default.nix | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/pkgs/applications/virtualization/virtualbox/default.nix b/pkgs/applications/virtualization/virtualbox/default.nix index f99338fb406..0d09716f8f2 100644 --- a/pkgs/applications/virtualization/virtualbox/default.nix +++ b/pkgs/applications/virtualization/virtualbox/default.nix @@ -20,10 +20,11 @@ let python = python2; buildType = "release"; # Manually sha256sum the extensionPack file, must be hex! - extpack = "9328548ca8cbc526232c0631cb5a17618c771b07665b362c1e3d89a2425bf799"; - extpackRev = "119230"; - main = "05y03fcp013gc500q34bj6hvx1banib41v8l3hcxknzfgwq0rarm"; - version = "5.2.2"; + # Do not forget to update the hash in ./guest-additions/default.nix! + extpack = "98e9df4f23212c3de827af9d770b391cf2dba8d21f4de597145512c1479302cd"; + extpackRev = "119785"; + main = "053xpf0kxrig4jq5djfz9drhkxy1x5a4p9qvgxc0b3hnk6yn1869"; + version = "5.2.4"; # See https://github.com/NixOS/nixpkgs/issues/672 for details extensionPack = requireFile rec { diff --git a/pkgs/applications/virtualization/virtualbox/guest-additions/default.nix b/pkgs/applications/virtualization/virtualbox/guest-additions/default.nix index 0aa0423fc13..409187a99fb 100644 --- a/pkgs/applications/virtualization/virtualbox/guest-additions/default.nix +++ b/pkgs/applications/virtualization/virtualbox/guest-additions/default.nix @@ -19,7 +19,7 @@ stdenv.mkDerivation { src = fetchurl { url = "http://download.virtualbox.org/virtualbox/${version}/VBoxGuestAdditions_${version}.iso"; - sha256 = "1f0vm20qdjxqsbciwgybxqqpn609gj5dy68an8lpi1wlk93s05w3"; + sha256 = "0qhsr6vc48ld2p9q3a6n6rfg57rsn163axr3r1m2yqr2snr4pnk0"; }; KERN_DIR = "${kernel.dev}/lib/modules/${kernel.modDirVersion}/build"; From 035dfacf43ed95a7e7c6ea722e91d7fabab43a7f Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Fri, 22 Dec 2017 12:21:08 +0100 Subject: [PATCH 2/4] virtualbox: add flokli as maintainer --- pkgs/applications/virtualization/virtualbox/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/virtualization/virtualbox/default.nix b/pkgs/applications/virtualization/virtualbox/default.nix index 0d09716f8f2..583fb408f1e 100644 --- a/pkgs/applications/virtualization/virtualbox/default.nix +++ b/pkgs/applications/virtualization/virtualbox/default.nix @@ -207,7 +207,7 @@ in stdenv.mkDerivation { meta = { description = "PC emulator"; homepage = http://www.virtualbox.org/; - maintainers = [ lib.maintainers.sander ]; + maintainers = with maintainers; [ flokli sander ]; platforms = [ "x86_64-linux" "i686-linux" ]; }; } From eb12741c7af5c2bffd9916ec6159297ba7d51aa2 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Fri, 22 Dec 2017 12:22:01 +0100 Subject: [PATCH 3/4] virtualbox: add license --- pkgs/applications/virtualization/virtualbox/default.nix | 1 + 1 file changed, 1 insertion(+) diff --git a/pkgs/applications/virtualization/virtualbox/default.nix b/pkgs/applications/virtualization/virtualbox/default.nix index 583fb408f1e..d46702d6205 100644 --- a/pkgs/applications/virtualization/virtualbox/default.nix +++ b/pkgs/applications/virtualization/virtualbox/default.nix @@ -206,6 +206,7 @@ in stdenv.mkDerivation { meta = { description = "PC emulator"; + license = licenses.gpl2; homepage = http://www.virtualbox.org/; maintainers = with maintainers; [ flokli sander ]; platforms = [ "x86_64-linux" "i686-linux" ]; From 0543dc77b17ea26318e96f19bfb642856b52aa65 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Sat, 23 Dec 2017 03:30:46 +0100 Subject: [PATCH 4/4] nixos/tests/virtualbox: remove mknod /dev/vda1 call With devtmpfs introduced in 0d27df280f7ed502bba65e2ea13469069f9b275a it is created automatically. See https://github.com/NixOS/nixpkgs/pull/32983#issuecomment-353703083 --- nixos/tests/virtualbox.nix | 3 --- 1 file changed, 3 deletions(-) diff --git a/nixos/tests/virtualbox.nix b/nixos/tests/virtualbox.nix index c519d7dae8b..5574293ba37 100644 --- a/nixos/tests/virtualbox.nix +++ b/nixos/tests/virtualbox.nix @@ -109,9 +109,6 @@ let } '' ${pkgs.parted}/sbin/parted --script /dev/vda mklabel msdos ${pkgs.parted}/sbin/parted --script /dev/vda -- mkpart primary ext2 1M -1s - . /sys/class/block/vda1/uevent - mknod /dev/vda1 b $MAJOR $MINOR - ${pkgs.e2fsprogs}/sbin/mkfs.ext4 /dev/vda1 ${pkgs.e2fsprogs}/sbin/tune2fs -c 0 -i 0 /dev/vda1 mkdir /mnt