From 90268efa3873e5f0de59e13c07ef0c995c60623a Mon Sep 17 00:00:00 2001 From: Will Dietz Date: Fri, 21 Sep 2018 08:33:57 -0500 Subject: [PATCH 1/2] cryus-sasl: cleanup, fix w/musl (although not at all musl-specific) musl is fixed by disabling update of config.{guess,sub}. --- .../development/libraries/cyrus-sasl/default.nix | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/pkgs/development/libraries/cyrus-sasl/default.nix b/pkgs/development/libraries/cyrus-sasl/default.nix index 7a9e3991aad..619c0801e96 100644 --- a/pkgs/development/libraries/cyrus-sasl/default.nix +++ b/pkgs/development/libraries/cyrus-sasl/default.nix @@ -36,15 +36,15 @@ stdenv.mkDerivation rec { configureFlags = [ "--with-openssl=${openssl.dev}" + "--with-plugindir=${placeholder "out"}/lib/sasl2" + "--with-saslauthd=/run/saslauthd" + "--enable-login" + "--enable-shared" ] ++ lib.optional enableLdap "--with-ldap=${openldap.dev}"; - # Set this variable at build-time to make sure $out can be evaluated. - preConfigure = '' - configureFlagsArray=( --with-plugindir=$out/lib/sasl2 - --with-saslauthd=/run/saslauthd - --enable-login - ) - ''; + # Avoid triggering regenerating using broken autoconf/libtool bits. + # (many distributions carry patches to remove/replace, but this works for now) + dontUpdateAutotoolsGnuConfigScripts = true; installFlags = lib.optional stdenv.isDarwin [ "framedir=$(out)/Library/Frameworks/SASL2.framework" ]; @@ -55,7 +55,7 @@ stdenv.mkDerivation rec { ''; meta = { - homepage = http://cyrusimap.web.cmu.edu/; + homepage = https://www.cyrusimap.org/sasl; description = "Library for adding authentication support to connection-based protocols"; platforms = platforms.unix; }; From c0660c4c00e03a57a0817ec27a542621bfbab018 Mon Sep 17 00:00:00 2001 From: Will Dietz Date: Mon, 24 Sep 2018 09:44:30 -0500 Subject: [PATCH 2/2] cyrus-sasl: set to null on non-musl per reviewer suggestion Unclear what the problem is exactly regarding regenerating files, so this makes the change only impact build configs known to need it. --- pkgs/development/libraries/cyrus-sasl/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/development/libraries/cyrus-sasl/default.nix b/pkgs/development/libraries/cyrus-sasl/default.nix index 619c0801e96..bc5e23581ff 100644 --- a/pkgs/development/libraries/cyrus-sasl/default.nix +++ b/pkgs/development/libraries/cyrus-sasl/default.nix @@ -44,7 +44,7 @@ stdenv.mkDerivation rec { # Avoid triggering regenerating using broken autoconf/libtool bits. # (many distributions carry patches to remove/replace, but this works for now) - dontUpdateAutotoolsGnuConfigScripts = true; + dontUpdateAutotoolsGnuConfigScripts = if stdenv.hostPlatform.isMusl then true else null; installFlags = lib.optional stdenv.isDarwin [ "framedir=$(out)/Library/Frameworks/SASL2.framework" ];