From c2f3556dc75ee09890c2cfc867cdb10df23accf6 Mon Sep 17 00:00:00 2001
From: Silvan Mosberger <contact@infinisil.com>
Date: Tue, 26 Jan 2021 22:30:07 +0100
Subject: [PATCH] lib/tests: More functionTo tests

---
 lib/tests/modules.sh                          |  8 +++--
 lib/tests/modules/functionTo.nix              | 29 -------------------
 lib/tests/modules/functionTo/list-order.nix   | 25 ++++++++++++++++
 .../modules/functionTo/merging-attrs.nix      | 27 +++++++++++++++++
 lib/tests/modules/functionTo/merging-list.nix | 24 +++++++++++++++
 lib/tests/modules/functionTo/trivial.nix      | 17 +++++++++++
 lib/tests/modules/functionTo/wrong-type.nix   | 18 ++++++++++++
 7 files changed, 117 insertions(+), 31 deletions(-)
 delete mode 100644 lib/tests/modules/functionTo.nix
 create mode 100644 lib/tests/modules/functionTo/list-order.nix
 create mode 100644 lib/tests/modules/functionTo/merging-attrs.nix
 create mode 100644 lib/tests/modules/functionTo/merging-list.nix
 create mode 100644 lib/tests/modules/functionTo/trivial.nix
 create mode 100644 lib/tests/modules/functionTo/wrong-type.nix

diff --git a/lib/tests/modules.sh b/lib/tests/modules.sh
index 2d3a696e980..f843d303e44 100755
--- a/lib/tests/modules.sh
+++ b/lib/tests/modules.sh
@@ -262,8 +262,12 @@ checkConfigOutput true config.value.mkbefore ./types-anything/mk-mods.nix
 checkConfigOutput 1 config.value.nested.foo ./types-anything/mk-mods.nix
 checkConfigOutput baz config.value.nested.bar.baz ./types-anything/mk-mods.nix
 
-# Check the merge behaviour of the functionTo type.
-checkConfigOutput "a b" config.result ./functionTo.nix
+## types.functionTo
+checkConfigOutput "input is input" config.result ./functionTo/trivial.nix
+checkConfigOutput "a b" config.result ./functionTo/merging-list.nix
+checkConfigError 'A definition for option .fun.\[function body\]. is not of type .string.. Definition values:\n- In .*wrong-type.nix' config.result ./functionTo/wrong-type.nix
+checkConfigOutput "b a" config.result ./functionTo/list-order.nix
+checkConfigOutput "a c" config.result ./functionTo/merging-attrs.nix
 
 cat <<EOF
 ====== module tests ======
diff --git a/lib/tests/modules/functionTo.nix b/lib/tests/modules/functionTo.nix
deleted file mode 100644
index 591d9a47f93..00000000000
--- a/lib/tests/modules/functionTo.nix
+++ /dev/null
@@ -1,29 +0,0 @@
-{ lib, config, ... }:
-
-with lib;
-
-{
-  options = {
-    selector = mkOption {
-      default = _pkgs : [];
-      type = with types; functionTo (listOf str);
-      description = ''
-        Some descriptive text
-      '';
-    };
-
-    result = mkOption {
-      type = types.str;
-      default = toString (config.selector {
-        a = "a";
-        b = "b";
-        c = "c";
-      });
-    };
-  };
-
-  config = lib.mkMerge [
-    { selector = pkgs: [ pkgs.a ]; }
-    { selector = pkgs: [ pkgs.b ]; }
-  ];
-}
diff --git a/lib/tests/modules/functionTo/list-order.nix b/lib/tests/modules/functionTo/list-order.nix
new file mode 100644
index 00000000000..77a1a43a84f
--- /dev/null
+++ b/lib/tests/modules/functionTo/list-order.nix
@@ -0,0 +1,25 @@
+
+{ lib, config, ... }:
+let
+  inherit (lib) types;
+in {
+  options = {
+    fun = lib.mkOption {
+      type = types.functionTo (types.listOf types.str);
+    };
+
+    result = lib.mkOption {
+      type = types.str;
+      default = toString (config.fun {
+        a = "a";
+        b = "b";
+        c = "c";
+      });
+    };
+  };
+
+  config.fun = lib.mkMerge [
+    (input: lib.mkAfter [ input.a ])
+    (input: [ input.b ])
+  ];
+}
diff --git a/lib/tests/modules/functionTo/merging-attrs.nix b/lib/tests/modules/functionTo/merging-attrs.nix
new file mode 100644
index 00000000000..97c015f928a
--- /dev/null
+++ b/lib/tests/modules/functionTo/merging-attrs.nix
@@ -0,0 +1,27 @@
+{ lib, config, ... }:
+let
+  inherit (lib) types;
+in {
+  options = {
+    fun = lib.mkOption {
+      type = types.functionTo (types.attrsOf types.str);
+    };
+
+    result = lib.mkOption {
+      type = types.str;
+      default = toString (lib.attrValues (config.fun {
+        a = "a";
+        b = "b";
+        c = "c";
+      }));
+    };
+  };
+
+  config.fun = lib.mkMerge [
+    (input: { inherit (input) a; })
+    (input: { inherit (input) b; })
+    (input: {
+      b = lib.mkForce input.c;
+    })
+  ];
+}
diff --git a/lib/tests/modules/functionTo/merging-list.nix b/lib/tests/modules/functionTo/merging-list.nix
new file mode 100644
index 00000000000..15fcd2bdcc4
--- /dev/null
+++ b/lib/tests/modules/functionTo/merging-list.nix
@@ -0,0 +1,24 @@
+{ lib, config, ... }:
+let
+  inherit (lib) types;
+in {
+  options = {
+    fun = lib.mkOption {
+      type = types.functionTo (types.listOf types.str);
+    };
+
+    result = lib.mkOption {
+      type = types.str;
+      default = toString (config.fun {
+        a = "a";
+        b = "b";
+        c = "c";
+      });
+    };
+  };
+
+  config.fun = lib.mkMerge [
+    (input: [ input.a ])
+    (input: [ input.b ])
+  ];
+}
diff --git a/lib/tests/modules/functionTo/trivial.nix b/lib/tests/modules/functionTo/trivial.nix
new file mode 100644
index 00000000000..0962a0cf893
--- /dev/null
+++ b/lib/tests/modules/functionTo/trivial.nix
@@ -0,0 +1,17 @@
+{ lib, config, ... }:
+let
+  inherit (lib) types;
+in {
+  options = {
+    fun = lib.mkOption {
+      type = types.functionTo types.str;
+    };
+
+    result = lib.mkOption {
+      type = types.str;
+      default = config.fun "input";
+    };
+  };
+
+  config.fun = input: "input is ${input}";
+}
diff --git a/lib/tests/modules/functionTo/wrong-type.nix b/lib/tests/modules/functionTo/wrong-type.nix
new file mode 100644
index 00000000000..fd65b75088d
--- /dev/null
+++ b/lib/tests/modules/functionTo/wrong-type.nix
@@ -0,0 +1,18 @@
+
+{ lib, config, ... }:
+let
+  inherit (lib) types;
+in {
+  options = {
+    fun = lib.mkOption {
+      type = types.functionTo types.str;
+    };
+
+    result = lib.mkOption {
+      type = types.str;
+      default = config.fun 0;
+    };
+  };
+
+  config.fun = input: input + 1;
+}