public
/
nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

python3Packages.psautohint: disable slow tests 

* Reduces test time from ~5 mins to ~30 seconds.
* Also converts to pytestCheckHook for better test control.
* Makes fetchFromGitHub variables match convention.
* remove pytest-randomly.
    pytest-randomly will randomize test order &
    reset random seeds between tests.
    We don't want the random test ordering for reproducible builds, so we
    remove it.
* Fixes flaky test "test_hashmap_old_version" by pinning pytest to v5,
    corresponding to upstream issue:
    https://github.com/adobe-type-tools/psautohint/issues/284#issuecomment-742800965

py3.psautohint: use pytest5
This commit is contained in:
Drew Risinger 2020-12-09 11:04:17 -05:00
parent 1183f62e9f
commit c2c9fcc896
1 changed files with 22 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
pkgs/development/python-modules/psautohint/default.nix
View File

@ -1,7 +1,7 @@
{ lib, buildPythonPackage, fetchFromGitHub, pythonOlder { lib, buildPythonPackage, fetchFromGitHub, pythonOlder
, fonttools, lxml, fs , fonttools, lxml, fs
, setuptools_scm , setuptools_scm
, pytest, pytestcov, pytest_xdist, pytest-randomly , pytestCheckHook, pytest_5, pytestcov, pytest_xdist
}: }:
buildPythonPackage rec { buildPythonPackage rec {
@ -13,8 +13,8 @@ buildPythonPackage rec {
src = fetchFromGitHub { src = fetchFromGitHub {
owner = "adobe-type-tools"; owner = "adobe-type-tools";
repo = pname; repo = pname;
sha256 = "1s2l54gzn11y07zaggprwif7r3ia244qijjhkbvjdx4jsgc5df8n";
rev = "v${version}"; rev = "v${version}";
sha256 = "1s2l54gzn11y07zaggprwif7r3ia244qijjhkbvjdx4jsgc5df8n";
fetchSubmodules = true; # data dir for tests fetchSubmodules = true; # data dir for tests
}; };
@ -28,8 +28,24 @@ buildPythonPackage rec {
propagatedBuildInputs = [ fonttools lxml fs ]; propagatedBuildInputs = [ fonttools lxml fs ];
checkInputs = [ pytest pytestcov pytest_xdist pytest-randomly ]; checkInputs = [
checkPhase = "pytest tests"; # Override pytestCheckHook to use pytest v5, because some tests fail on pytest >= v6
# https://github.com/adobe-type-tools/psautohint/issues/284#issuecomment-742800965
# Override might be able to be removed in future, check package dependency pins (coverage.yml)
(pytestCheckHook.override{ pytest = pytest_5; })
pytestcov
pytest_xdist
];
disabledTests = [
# Slow tests, reduces test time from ~5 mins to ~30s
"test_mmufo"
"test_flex_ufo"
"test_ufo"
"test_flex_otf"
"test_multi_outpath"
"test_mmhint"
"test_otf"
];
meta = with lib; { meta = with lib; {
description = "Script to normalize the XML and other data inside of a UFO"; description = "Script to normalize the XML and other data inside of a UFO";