From 239d35208002fab892ce2d912c8adeaf05e49992 Mon Sep 17 00:00:00 2001 From: Pascal Bach Date: Sun, 30 Apr 2017 23:16:33 +0200 Subject: [PATCH 1/2] openshift: 1.3.2 -> 1.5.0 --- .../networking/cluster/openshift/default.nix | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/pkgs/applications/networking/cluster/openshift/default.nix b/pkgs/applications/networking/cluster/openshift/default.nix index 403457bb4a6..a01054a828d 100644 --- a/pkgs/applications/networking/cluster/openshift/default.nix +++ b/pkgs/applications/networking/cluster/openshift/default.nix @@ -1,7 +1,7 @@ -{ stdenv, fetchFromGitHub, go, which }: +{ stdenv, fetchFromGitHub, go, which, removeReferencesTo, makeWrapper }: let - version = "1.3.2"; + version = "1.5.0"; ver = stdenv.lib.elemAt (stdenv.lib.splitString "." version); versionMajor = ver 0; versionMinor = ver 1; @@ -15,10 +15,10 @@ stdenv.mkDerivation rec { owner = "openshift"; repo = "origin"; rev = "v${version}"; - sha256 = "0zw8zb9c6icigcq6y47ppnjnqyghk2kril07bapbddvgnvbbfp6m"; + sha256 = "0qvyxcyca3888nkgvyvqcmybm95ncwxb3zvrzbg2gz8kx6g6350v"; }; - buildInputs = [ go which ]; + buildInputs = [ go which removeReferencesTo makeWrapper ]; patchPhase = '' patchShebangs ./hack @@ -41,6 +41,10 @@ stdenv.mkDerivation rec { mv _output/local/bin/$GOOS/$GOARCH/* "$out/bin/" ''; + preFixup = '' + find $out/bin -type f -exec remove-references-to -t ${go} '{}' + + ''; + meta = with stdenv.lib; { description = "Build, deploy, and manage your applications with Docker and Kubernetes"; license = licenses.asl20; From 878a1662d7350f8d35516d1df92ba938fb6349e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= Date: Mon, 1 May 2017 22:07:41 +0200 Subject: [PATCH 2/2] openshift: use buildGoPackage --- .../networking/cluster/openshift/default.nix | 20 +++++++------------ 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/pkgs/applications/networking/cluster/openshift/default.nix b/pkgs/applications/networking/cluster/openshift/default.nix index a01054a828d..3915ab6cc26 100644 --- a/pkgs/applications/networking/cluster/openshift/default.nix +++ b/pkgs/applications/networking/cluster/openshift/default.nix @@ -1,4 +1,4 @@ -{ stdenv, fetchFromGitHub, go, which, removeReferencesTo, makeWrapper }: +{ stdenv, fetchFromGitHub, which, buildGoPackage }: let version = "1.5.0"; @@ -6,8 +6,7 @@ let versionMajor = ver 0; versionMinor = ver 1; versionPatch = ver 2; -in -stdenv.mkDerivation rec { +in buildGoPackage rec { name = "openshift-origin-${version}"; inherit version; @@ -18,14 +17,15 @@ stdenv.mkDerivation rec { sha256 = "0qvyxcyca3888nkgvyvqcmybm95ncwxb3zvrzbg2gz8kx6g6350v"; }; - buildInputs = [ go which removeReferencesTo makeWrapper ]; + buildInputs = [ which ]; + goPackagePath = null; patchPhase = '' patchShebangs ./hack ''; buildPhase = '' - export GOPATH=$(pwd) + cd go/src/origin-v${version}-src # Openshift build require this variables to be set # unless there is a .git folder which is not the case with fetchFromGitHub export OS_GIT_VERSION=${version} @@ -35,14 +35,8 @@ stdenv.mkDerivation rec { ''; installPhase = '' - export GOOS=$(go env GOOS) - export GOARCH=$(go env GOARCH) - mkdir -p "$out/bin" - mv _output/local/bin/$GOOS/$GOARCH/* "$out/bin/" - ''; - - preFixup = '' - find $out/bin -type f -exec remove-references-to -t ${go} '{}' + + mkdir -p "$bin/bin" + cp "_output/local/bin/$(go env GOOS)/$(go env GOARCH)/"* "$bin/bin/" ''; meta = with stdenv.lib; {