From d516f12dbae4fccf184cef11ce49529b56e9df39 Mon Sep 17 00:00:00 2001 From: Samuel Rivas Date: Tue, 28 Jul 2015 17:30:40 +0200 Subject: [PATCH 1/2] camlp4: 4.02.0+1 -> 4.02+6 * Remove unneeded substitution in postConfigure This was fixed here: https://github.com/ocaml/camlp4/commit/81ed5cf2e857c08e433d891328767ad7f07f1447 * camlp4: use fetchzip It is considered more reliable than fetchurl --- pkgs/development/tools/ocaml/camlp4/default.nix | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/pkgs/development/tools/ocaml/camlp4/default.nix b/pkgs/development/tools/ocaml/camlp4/default.nix index a8043a9fc5e..20373c923e7 100644 --- a/pkgs/development/tools/ocaml/camlp4/default.nix +++ b/pkgs/development/tools/ocaml/camlp4/default.nix @@ -1,15 +1,17 @@ -{stdenv, fetchurl, which, ocaml}: +{stdenv, fetchzip, which, ocaml}: let ocaml_version = (stdenv.lib.getVersion ocaml); + version = "4.02+6"; + in assert stdenv.lib.versionAtLeast ocaml_version "4.02"; stdenv.mkDerivation { - name = "camlp4-4.02.0+1"; - src = fetchurl { - url = https://github.com/ocaml/camlp4/archive/4.02.0+1.tar.gz; - sha256 = "0055f4jiz82rgn581xhq3mr4qgq2qgdxqppmp8i2x1xnsim4h9pn"; + name = "camlp4-${version}"; + src = fetchzip { + url = "https://github.com/ocaml/camlp4/archive/${version}.tar.gz"; + sha256 = "06yl4q0qazl7g25b0axd1gdkfd4qpqzs1gr5fkvmkrcbz113h1hj"; }; buildInputs = [ which ocaml ]; @@ -27,10 +29,6 @@ stdenv.mkDerivation { postConfigure = '' substituteInPlace camlp4/META.in \ --replace +camlp4 $out/lib/ocaml/${ocaml_version}/site-lib/camlp4 - substituteInPlace camlp4/config/Camlp4_config.ml \ - --replace \ - "Filename.concat ocaml_standard_library" \ - "Filename.concat \"$out/lib/ocaml/${ocaml_version}/site-lib\"" ''; From 37d0d8ac7411af01761dbaf58bfa7d673453af2a Mon Sep 17 00:00:00 2001 From: Samuel Rivas Date: Tue, 28 Jul 2015 17:31:44 +0200 Subject: [PATCH 2/2] utop: 1.15 -> 1.17 Version 1.18 doesn't compile cleanly currently, I need to debug what is going on there --- pkgs/development/tools/ocaml/utop/default.nix | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/pkgs/development/tools/ocaml/utop/default.nix b/pkgs/development/tools/ocaml/utop/default.nix index c5c0ac9a3ed..c9addf55312 100644 --- a/pkgs/development/tools/ocaml/utop/default.nix +++ b/pkgs/development/tools/ocaml/utop/default.nix @@ -1,22 +1,24 @@ {stdenv, fetchurl, ocaml, findlib, lambdaTerm, ocaml_lwt, makeWrapper, - ocaml_react, camomile, zed + ocaml_react, camomile, zed, cppo, camlp4 }: stdenv.mkDerivation rec { - version = "1.15"; + version = "1.17"; name = "utop-${version}"; src = fetchurl { - url = https://github.com/diml/utop/archive/1.15.tar.gz; - sha256 = "106v0x6sa2x10zgmjf73mpzws7xiqanxswivd00iqnpc0bcpkmrr"; + url = "https://github.com/diml/utop/archive/${version}.tar.gz"; + sha256 = "0l9lz2nypl2ls3kqzmp738m02yvscabhsfpj70ckp0p98pimnnfd"; }; - buildInputs = [ ocaml findlib makeWrapper]; + buildInputs = [ ocaml findlib makeWrapper cppo camlp4 ]; propagatedBuildInputs = [ lambdaTerm ocaml_lwt ]; createFindlibDestdir = true; + configureFlags = "--enable-camlp4"; + buildPhase = '' make make doc