public/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

prometheus: gross hack to fix linker flags for versioning info

Browse Source 
Apparently the handling of `buildFlagsArray` in `buildGo*` is blatantly
broken since it doesn't quote flags specified as list elements properly.

Because of that, the `-ldflags` are not interpreted properly and
`prometheus --version` doesn't output anything useful. By specifying
flags in both `buildFlags` and `buildFlagsArray` the issue gets fixed
since both variables are passed to `go install`.
This commit is contained in:
Maximilian Bosch 2020-12-23 16:36:02 +01:00
parent 5a26fb3c98
commit b33b086506
No known key found for this signature in database
GPG Key ID: 091DBF4D1FC46B8E
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkgs/servers/monitoring/prometheus/default.nix
View File

@ -44,10 +44,10 @@ in buildGoPackage rec {
ln -s ${webui} web/ui/static/react ln -s ${webui} web/ui/static/react
''; '';
buildFlags = "-tags=builtinassets";
buildFlagsArray = let buildFlagsArray = let
t = "${goPackagePath}/vendor/github.com/prometheus/common/version"; t = "${goPackagePath}/vendor/github.com/prometheus/common/version";
in [ in [
"-tags=builtinassets"
'' ''
-ldflags= -ldflags=
-X ${t}.Version=${version} -X ${t}.Version=${version}