public/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "ocamlPackages.tcpip: 6.0.0 -> 6.1.0"

Browse Source 
This reverts commit 988f5a5910bdba12f34b500e0dc3aa60042a75a6.

The release process for many OCaml packages and in extension mirage
related packages usually entails creating a release in the respective
own repository so a release tarball becomes available and then opening a
PR against ocaml/opam-repository to finalize the release. During this
new issues can be discovered which push the release back.

This happened for mirage-tcpip 6.1.0 several times:
https://github.com/ocaml/opam-repository/pull/18357
Prompting in total 3 different 6.1.0 releases with different hashes
respectively (the hash for ocamlPackages.tcpip.src shouldn't be
reproducible anymore, but we probably have cached the tarball already).
Ultimately the PR to opam-repository was closed to investigate some
failures on opam-repository's CI and the release postponed:
https://github.com/ocaml/opam-repository/pull/18357#issuecomment-808434285

I jumped the gun with the release and updated tcpip in nixpkgs before
tcpip was “properly” released in opam. I usually watch the github
repository of package I maintain for releases and can react pretty
quickly to a release as a result. Most of the time I also check
opam-repository's PRs nowadays for extra context or information, but
when everything seems fine and tests succeed I deem the update alright
to PR to nixpkgs. Being faster than opam was achievable in these cases
and actually seems kind of tantalizing.

In the light of this experience however, we should wait for the opam
PR getting merged at least for some packages that exhibit this behavior
of rereleasing the same version number multiple times to get the release
just right (afaik the 6.1.0 tag pointed to three different revisions for
tcpip). To me this is questionable upstream behavior we just have to deal
with in some way.
This commit is contained in:
sternenseemann 2021-03-27 00:57:34 +01:00 committed by Vincent Laporte
parent 477812e18e
commit b2eb2c8b4f
2 changed files with 3 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkgs/development/ocaml-modules/tcpip/default.nix
View File

@ -1,5 +1,5 @@
{ lib, buildDunePackage, fetchurl
, bisect_ppx, ppx_cstruct, pkg-config
, bisect_ppx, ppx_cstruct
, rresult, cstruct, cstruct-lwt, mirage-net, mirage-clock
, mirage-random, mirage-stack, mirage-protocols, mirage-time
, ipaddr, macaddr, macaddr-cstruct, mirage-profile, fmt
@ -11,23 +11,18 @@
buildDunePackage rec {
pname = "tcpip";
version = "6.1.0";
version = "6.0.0";
useDune2 = true;
src = fetchurl {
url = "https://github.com/mirage/mirage-${pname}/releases/download/v${version}/${pname}-v${version}.tbz";
sha256 = "e81c98a6e80e05f9fa4e5fbee50e6c247f6011254c7b1d9a0e58bae318c1f0c8";
sha256 = "0wbrs8jz1vw3zdrqmqcwawxh4yhc2gy30rw7gz4w116cblkvnb8s";
};
patches = [
./no-opam-pkg-config-path.patch
];
nativeBuildInputs = [
bisect_ppx
ppx_cstruct
pkg-config
];
propagatedBuildInputs = [

21
pkgs/development/ocaml-modules/tcpip/no-opam-pkg-config-path.patch
View File

@ -1,21 +0,0 @@
diff --git a/freestanding/Makefile b/freestanding/Makefile
index f22d220d..4bb3ac57 100644
--- a/freestanding/Makefile
+++ b/freestanding/Makefile
@@ -1,6 +1,4 @@
-PKG_CONFIG_PATH := $(shell opam config var prefix)/lib/pkgconfig
-
-EXISTS := $(shell PKG_CONFIG_PATH=$(PKG_CONFIG_PATH) pkg-config --exists ocaml-freestanding; echo $$?)
+EXISTS := $(shell pkg-config --exists ocaml-freestanding; echo $$?)
.PHONY: all clean
all: libtcpip_freestanding_stubs.a
@@ -10,7 +8,7 @@ libtcpip_freestanding_stubs.a:
touch $@
else
CC ?= cc
-FREESTANDING_CFLAGS := $(shell PKG_CONFIG_PATH=$(PKG_CONFIG_PATH) pkg-config --cflags ocaml-freestanding)
+FREESTANDING_CFLAGS := $(shell pkg-config --cflags ocaml-freestanding)
CFLAGS := $(FREESTANDING_CFLAGS)
OBJS=checksum_stubs.o