public/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #48325 from transumption/201810/warn-on-fetchurl-rev-archives

Browse Source 
fetchurl: warn on rev archives, resolves #32999
This commit is contained in:
Graham Christensen 2019-04-24 12:09:35 -04:00 committed by GitHub
commit b26153450c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkgs/build-support/fetchurl/builder.sh
View File

@ -118,7 +118,6 @@ if test -n "$showURLs"; then
exit 0 exit 0
fi fi
if test -n "$preferHashedMirrors"; then if test -n "$preferHashedMirrors"; then
tryHashedMirrors tryHashedMirrors
fi fi
@ -128,6 +127,16 @@ set -o noglob
success= success=
for url in $urls; do for url in $urls; do
if [ -z "$postFetch" ]; then
case "$url" in
https://github.com/*/archive/*)
echo "warning: archives from GitHub revisions should use fetchFromGitHub"
;;
https://gitlab.com/*/-/archive/*)
echo "warning: archives from GitLab revisions should use fetchFromGitLab"
;;
esac
fi
tryDownload "$url" tryDownload "$url"
if test -n "$success"; then finish; fi if test -n "$success"; then finish; fi
done done