From ad078d83a467c6e6fe80c33008a68eef66a8b2e5 Mon Sep 17 00:00:00 2001 From: Nejc Zupan Date: Wed, 13 Nov 2019 15:28:27 +0000 Subject: [PATCH] Add checkPhase for pipenv This is to prevent regressions such as https://github.com/NixOS/nixpkgs/issues/73254 by using pipenv to install a simple Python package, thus testing that pipenv was built correctly. Many thanks to @Infinisil and @domenkozar for hand-holding! --- pkgs/development/tools/pipenv/default.nix | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkgs/development/tools/pipenv/default.nix b/pkgs/development/tools/pipenv/default.nix index de9e02de3f7..9a576f12e95 100644 --- a/pkgs/development/tools/pipenv/default.nix +++ b/pkgs/development/tools/pipenv/default.nix @@ -39,7 +39,11 @@ in buildPythonApplication rec { propagatedBuildInputs = runtimeDeps; - doCheck = false; + doCheck = true; + checkPhase = '' + export HOME=$PWD + $out/bin/pipenv install ${fetchPypi {pname="pyjokes"; version="0.6.0"; sha256="08860eedb78cbfa4618243c8db088f21c39823ece1fdaf0133e52d9c56e981a5";} } + ''; meta = with lib; { description = "Python Development Workflow for Humans";