From ab77228749626b00b726d7050f3e02ef1865218e Mon Sep 17 00:00:00 2001 From: Peter Simons Date: Thu, 23 Jul 2015 22:16:16 +0200 Subject: [PATCH] haskell-generic-builder: improve recognition of pkgconfig dependencies --- pkgs/development/haskell-modules/generic-builder.nix | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/pkgs/development/haskell-modules/generic-builder.nix b/pkgs/development/haskell-modules/generic-builder.nix index 2af3d964619..26643f075b0 100644 --- a/pkgs/development/haskell-modules/generic-builder.nix +++ b/pkgs/development/haskell-modules/generic-builder.nix @@ -45,7 +45,6 @@ , useCpphs ? false } @ args: -assert pkgconfigDepends != [] -> pkgconfig != null; assert editedCabalFile != null -> revision != null; let @@ -105,10 +104,13 @@ let isHaskellPkg = x: (x ? pname) && (x ? version) && (x ? env); isSystemPkg = x: !isHaskellPkg x; + allPkgconfigDepends = pkgconfigDepends ++ libraryPkgconfigDepends ++ executablePkgconfigDepends ++ + optionals doCheck testPkgconfigDepends; + propagatedBuildInputs = buildDepends ++ libraryHaskellDepends ++ executableHaskellDepends; otherBuildInputs = extraLibraries ++ librarySystemDepends ++ executableSystemDepends ++ buildTools ++ libraryToolDepends ++ executableToolDepends ++ - optionals (pkgconfigDepends != []) ([pkgconfig] ++ pkgconfigDepends ++ libraryPkgconfigDepends ++ executablePkgconfigDepends) ++ + optionals (allPkgconfigDepends != []) ([pkgconfig] ++ allPkgconfigDepends) ++ optionals doCheck (testDepends ++ testHaskellDepends ++ testSystemDepends); allBuildInputs = propagatedBuildInputs ++ otherBuildInputs; @@ -122,6 +124,9 @@ let ghcCommandCaps = toUpper ghcCommand; in + +assert allPkgconfigDepends != [] -> pkgconfig != null; + stdenv.mkDerivation ({ name = "${optionalString (hasActiveLibrary && pname != "ghcjs") "haskell-"}${pname}-${version}";