palemoon: 27.9.4 -> 28.6.0.1, slight refactor

· Added new (/previously unnoticed?) dependencies.
· Refactored to use pname, quoted homepage, better description.
· Added myself to maintainers.
· Configuration changed according to upstream documentation.
· Build & Install phases simplified/refactored to be more like Arch's PKGBUILD.

pkgs/applications/networking/browsers/palemoon/default.nix

@@ -1,23 +1,23 @@
 { stdenv, fetchFromGitHub, makeDesktopItem
 , pkgconfig, autoconf213, alsaLib, bzip2, cairo
 , dbus, dbus-glib, file, fontconfig, freetype
-, gstreamer, gst-plugins-base, gst_all_1
+, gnome2, gnum4, gstreamer, gst-plugins-base, gst_all_1
 , gtk2, hunspell, icu, libevent, libjpeg, libnotify
 , libstartup_notification, libvpx, makeWrapper, libGLU_combined
 , nspr, nss, pango, perl, python, libpulseaudio, sqlite
-, unzip, xorg, which, yasm, zip, zlib
+, unzip, xorg, wget, which, yasm, zip, zlib
 }:
 
 stdenv.mkDerivation rec {
-  name = "palemoon-${version}";
+  pname = "palemoon";
-  version = "27.9.4";
+  version = "28.6.0.1";
 
   src = fetchFromGitHub {
-    name   = "palemoon-src";
+    name   = "${pname}-${version}";
     owner  = "MoonchildProductions";
-    repo   = "Pale-Moon";
+    repo   = "UXP";
-    rev    = version + "_Release";
+    rev    = "PM${version}_Release";
-    sha256 = "0ir5gzhw98gfn15x58g1fwi11jd7gysvacqxg1v0jdjhgdl4m5sx";
+    sha256 = "1adgajy5vsghvjlv2nqyrbp6mnv3k6slqxxi8r949xlb5h6d210b";
   };
 
   desktopItem = makeDesktopItem {
@@ -40,10 +40,10 @@ stdenv.mkDerivation rec {
 
   buildInputs = [
     alsaLib bzip2 cairo dbus dbus-glib file fontconfig freetype
-    gst-plugins-base gstreamer gst_all_1.gst-plugins-base gtk2
+    gnome2.GConf gnum4 gst-plugins-base gstreamer gst_all_1.gst-plugins-base gtk2
     hunspell icu libevent libjpeg libnotify libstartup_notification
     libvpx makeWrapper libGLU_combined nspr nss pango perl pkgconfig python
-    libpulseaudio sqlite unzip which yasm zip zlib
+    libpulseaudio sqlite unzip wget which yasm zip zlib
   ] ++ (with xorg; [
     libX11 libXext libXft libXi libXrender libXScrnSaver
     libXt pixman xorgproto
@@ -52,57 +52,65 @@ stdenv.mkDerivation rec {
   enableParallelBuilding = true;
 
   configurePhase = ''
-    export AUTOCONF=${autoconf213}/bin/autoconf
+    export MOZBUILD_STATE_PATH=$(pwd)/mozbuild
-    export MOZBUILD_STATE_PATH=$(pwd)/.mozbuild
+    export MOZCONFIG=$(pwd)/mozconfig
-    export MOZ_CONFIG=$(pwd)/.mozconfig
+    export builddir=$(pwd)/pmbuild
-    export builddir=$(pwd)/build
+
-    mkdir -p $MOZBUILD_STATE_PATH $builddir
+    echo > $MOZCONFIG "
-    echo > $MOZ_CONFIG "
+    mk_add_options AUTOCLOBBER=1
-    . $src/build/mozconfig.common
+    mk_add_options MOZ_OBJDIR=$builddir
-    ac_add_options --prefix=$out
+    ac_add_options --enable-application=palemoon
-    ac_add_options --with-pthreads
+
-    ac_add_options --enable-application=browser
+    ac_add_options --enable-optimize='-O2'
+
+    # Please see https://www.palemoon.org/redist.shtml for restrictions when using the official branding.
     ac_add_options --enable-official-branding
-    ac_add_options --enable-optimize="-O2"
+    export MOZILLA_OFFICIAL=1
-    ac_add_options --enable-release
+
-    ac_add_options --enable-devtools
+    ac_add_options --enable-default-toolkit=cairo-gtk2
     ac_add_options --enable-jemalloc
-    ac_add_options --enable-shared-js
     ac_add_options --enable-strip
+    ac_add_options --with-pthreads
+
     ac_add_options --disable-tests
-    ac_add_options --disable-installer
+    ac_add_options --disable-eme
-    ac_add_options --disable-updaters
+    ac_add_options --disable-parental-controls
+    ac_add_options --disable-accessibility
+    ac_add_options --disable-webrtc
+    ac_add_options --disable-gamepad
+    ac_add_options --disable-necko-wifi
+    ac_add_options --disable-updater
+
+    ac_add_options --x-libraries=${xorg.libX11.out}/lib
+
+    ac_add_options --prefix=$out
+    mk_add_options MOZ_MAKE_FLAGS='-j$NIX_BUILD_CORES'
+    mk_add_options AUTOCONF=${autoconf213}/bin/autoconf
     "
   '';
 
-  patchPhase = ''
-    chmod u+w .
-  '';
-
   hardeningDisable = [ "format" ];
-  
+
   buildPhase = ''
-    cd $builddir
     $src/mach build
   '';
 
   installPhase = ''
+    $src/mach install
+
     mkdir -p $out/share/applications
     cp ${desktopItem}/share/applications/* $out/share/applications
 
     for n in 16 22 24 32 48 256; do
       size=$n"x"$n
       mkdir -p $out/share/icons/hicolor/$size/apps
-      cp $src/browser/branding/official/default$n.png \
+      cp $src/application/palemoon/branding/official/default$n.png \
          $out/share/icons/hicolor/$size/apps/palemoon.png
     done
-
-    cd $builddir
-    $src/mach install
   '';
 
   meta = with stdenv.lib; {
-    description = "A web browser";
+    description = "An Open Source, Goanna-based web browser focusing on efficiency and customization";
     longDescription = ''
       Pale Moon is an Open Source, Goanna-based web browser focusing on
       efficiency and customization.
@@ -114,9 +122,9 @@ stdenv.mkDerivation rec {
       experience, while offering full customization and a growing collection of
       extensions and themes to make the browser truly your own.
     '';
-    homepage    = https://www.palemoon.org/;
+    homepage    = "https://www.palemoon.org/";
     license     = licenses.mpl20;
-    maintainers = with maintainers; [ rnhmjoj AndersonTorres ];
+    maintainers = with maintainers; [ rnhmjoj AndersonTorres OPNA2608 ];
     platforms   = platforms.linux;
   };
 }