From a5f026f77855c6b2ea782e56b54544ad7095902a Mon Sep 17 00:00:00 2001 From: Thomas Tuegel Date: Mon, 16 Jul 2018 05:34:03 -0500 Subject: [PATCH] emacsPackagesNg.magit: find Git during build --- .../editors/emacs-modes/melpa-packages.nix | 15 ++++++++++----- .../editors/emacs-modes/melpa-stable-packages.nix | 13 ++++++++++++- pkgs/top-level/all-packages.nix | 3 ++- pkgs/top-level/emacs-packages.nix | 2 +- 4 files changed, 25 insertions(+), 8 deletions(-) diff --git a/pkgs/applications/editors/emacs-modes/melpa-packages.nix b/pkgs/applications/editors/emacs-modes/melpa-packages.nix index c21db447e39..3d432158651 100644 --- a/pkgs/applications/editors/emacs-modes/melpa-packages.nix +++ b/pkgs/applications/editors/emacs-modes/melpa-packages.nix @@ -124,11 +124,16 @@ self: # upstream issue: missing file header maxframe = markBroken super.maxframe; - # version of magit-popup needs to match magit - # https://github.com/magit/magit/issues/3286 - magit = super.magit.override { - inherit (self.melpaPackages) magit-popup; - }; + magit = + (super.magit.override { + # version of magit-popup needs to match magit + # https://github.com/magit/magit/issues/3286 + inherit (self.melpaPackages) magit-popup; + }).overrideAttrs (attrs: { + # searches for Git at build time + nativeBuildInputs = + (attrs.nativeBuildInputs or []) ++ [ external.git ]; + }); # missing OCaml merlin = markBroken super.merlin; diff --git a/pkgs/applications/editors/emacs-modes/melpa-stable-packages.nix b/pkgs/applications/editors/emacs-modes/melpa-stable-packages.nix index 33473ecad3f..bf0d5036897 100644 --- a/pkgs/applications/editors/emacs-modes/melpa-stable-packages.nix +++ b/pkgs/applications/editors/emacs-modes/melpa-stable-packages.nix @@ -13,7 +13,7 @@ To update the list of packages from MELPA, */ -{ lib }: +{ lib, external }: self: @@ -132,6 +132,17 @@ self: # upstream issue: missing file header maxframe = markBroken super.maxframe; + magit = + (super.magit.override { + # version of magit-popup needs to match magit + # https://github.com/magit/magit/issues/3286 + inherit (self.melpaStablePackages) magit-popup; + }).overrideAttrs (attrs: { + # searches for Git at build time + nativeBuildInputs = + (attrs.nativeBuildInputs or []) ++ [ external.git ]; + }); + # missing OCaml merlin = markBroken super.merlin; diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 46d0e93752f..6bb369adb7c 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -15905,7 +15905,8 @@ with pkgs; external = { inherit (haskellPackages) ghc-mod structured-haskell-mode Agda hindent; inherit (pythonPackages) elpy; - inherit rtags libffi autoconf automake libpng zlib poppler pkgconfig w3m; + inherit + autoconf automake git libffi libpng pkgconfig poppler rtags w3m zlib; }; }; diff --git a/pkgs/top-level/emacs-packages.nix b/pkgs/top-level/emacs-packages.nix index 1d522f0e9e8..f6c992d5bd5 100644 --- a/pkgs/top-level/emacs-packages.nix +++ b/pkgs/top-level/emacs-packages.nix @@ -50,7 +50,7 @@ let }; melpaStablePackages = import ../applications/editors/emacs-modes/melpa-stable-packages.nix { - inherit lib; + inherit external lib; }; melpaPackages = import ../applications/editors/emacs-modes/melpa-packages.nix {