From a33ab04d1b7ab4e8df867e8e05cb5b55222d5fe5 Mon Sep 17 00:00:00 2001
From: Thomas Tuegel <ttuegel@mailbox.org>
Date: Sat, 25 Feb 2017 13:54:09 -0600
Subject: [PATCH] Clean up KDE Frameworks

---
 .../libraries/kde-frameworks/default.nix      | 12 ++--------
 .../extra-cmake-modules/default.nix           | 22 ++++---------------
 .../extra-cmake-modules/no-hooks.nix          | 18 +++++++++++++++
 .../{ => extra-cmake-modules}/setup-hook.sh   |  0
 4 files changed, 24 insertions(+), 28 deletions(-)
 create mode 100644 pkgs/development/libraries/kde-frameworks/extra-cmake-modules/no-hooks.nix
 rename pkgs/development/libraries/kde-frameworks/{ => extra-cmake-modules}/setup-hook.sh (100%)

diff --git a/pkgs/development/libraries/kde-frameworks/default.nix b/pkgs/development/libraries/kde-frameworks/default.nix
index cb73bbddda7..ffb8fb04078 100644
--- a/pkgs/development/libraries/kde-frameworks/default.nix
+++ b/pkgs/development/libraries/kde-frameworks/default.nix
@@ -78,16 +78,8 @@ let
     baloo = callPackage ./baloo.nix {};
     bluez-qt = callPackage ./bluez-qt.nix {};
     breeze-icons = callPackage ./breeze-icons.nix {};
-    # FIXME: this collides with the "ecm" package.
-    ecm =
-      let drv = { cmake, ecmNoHooks, pkgconfig, qtbase, qttools }:
-            makeSetupHook
-            { deps = lib.chooseDevOutputs [ cmake ecmNoHooks pkgconfig qtbase qttools ]; }
-            ./setup-hook.sh;
-      in callPackage drv {};
-    ecmNoHooks = callPackage ./extra-cmake-modules {
-      inherit (srcs.extra-cmake-modules) src version;
-    };
+    ecm = callPackage ./extra-cmake-modules {};
+    ecmNoHooks = callPackage ./extra-cmake-modules/no-hooks.nix {};
     frameworkintegration = callPackage ./frameworkintegration.nix {};
     kactivities = callPackage ./kactivities.nix {};
     kactivities-stats = callPackage ./kactivities-stats.nix {};
diff --git a/pkgs/development/libraries/kde-frameworks/extra-cmake-modules/default.nix b/pkgs/development/libraries/kde-frameworks/extra-cmake-modules/default.nix
index d2f1688e330..6c0919a2361 100644
--- a/pkgs/development/libraries/kde-frameworks/extra-cmake-modules/default.nix
+++ b/pkgs/development/libraries/kde-frameworks/extra-cmake-modules/default.nix
@@ -1,20 +1,6 @@
-{ stdenv, lib, copyPathsToStore, src, version, cmake }:
+{ makeSetupHook, lib, cmake, ecmNoHooks, pkgconfig, qtbase, qttools }:
 
-stdenv.mkDerivation {
-  name = "extra-cmake-modules-${version}";
-
-  inherit src;
-
-  patches = copyPathsToStore (lib.readPathsFromFile ./. ./series);
-
-  outputs = [ "out" ];  # this package has no runtime components
-
-  nativeBuildInputs = [ cmake ];
-
-  meta = with lib; {
-    platforms = lib.platforms.linux;
-    homepage = "http://www.kde.org";
-    license = licenses.bsd2;
-    maintainers = [ maintainers.ttuegel ];
-  };
+makeSetupHook {
+  deps = lib.chooseDevOutputs [ cmake ecmNoHooks pkgconfig qtbase qttools ];
 }
+./setup-hook.sh
diff --git a/pkgs/development/libraries/kde-frameworks/extra-cmake-modules/no-hooks.nix b/pkgs/development/libraries/kde-frameworks/extra-cmake-modules/no-hooks.nix
new file mode 100644
index 00000000000..855d6bdb3d2
--- /dev/null
+++ b/pkgs/development/libraries/kde-frameworks/extra-cmake-modules/no-hooks.nix
@@ -0,0 +1,18 @@
+{ kdeFramework, lib, copyPathsToStore, cmake }:
+
+kdeFramework {
+  name = "extra-cmake-modules";
+
+  patches = copyPathsToStore (lib.readPathsFromFile ./. ./series);
+
+  outputs = [ "out" ];  # this package has no runtime components
+
+  nativeBuildInputs = [ cmake ];
+
+  meta = with lib; {
+    platforms = lib.platforms.linux;
+    homepage = "http://www.kde.org";
+    license = licenses.bsd2;
+    maintainers = [ maintainers.ttuegel ];
+  };
+}
diff --git a/pkgs/development/libraries/kde-frameworks/setup-hook.sh b/pkgs/development/libraries/kde-frameworks/extra-cmake-modules/setup-hook.sh
similarity index 100%
rename from pkgs/development/libraries/kde-frameworks/setup-hook.sh
rename to pkgs/development/libraries/kde-frameworks/extra-cmake-modules/setup-hook.sh