From 9dd6537303d18f21d4d7bba23dd9a528e1374814 Mon Sep 17 00:00:00 2001 From: Frederik Rietdijk Date: Sat, 31 Aug 2019 13:57:57 +0200 Subject: [PATCH] pythonPackages.tld: use pythonImportsCheck and pytestCheckHook --- pkgs/development/python-modules/tld/default.nix | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/pkgs/development/python-modules/tld/default.nix b/pkgs/development/python-modules/tld/default.nix index 3a21ce57fe7..b3d83deeac9 100644 --- a/pkgs/development/python-modules/tld/default.nix +++ b/pkgs/development/python-modules/tld/default.nix @@ -10,20 +10,25 @@ python.pkgs.buildPythonPackage rec { }; propagatedBuildInputs = with python.pkgs; [ six ]; - checkInputs = with python.pkgs; [ factory_boy faker pytest pytestcov tox ]; + checkInputs = with python.pkgs; [ factory_boy faker pytestcov tox pytestCheckHook]; # https://github.com/barseghyanartur/tld/issues/54 - disabledTests = stdenv.lib.concatMapStringsSep " and " (s: "not " + s) ([ + disabledTests = [ "test_1_update_tld_names" "test_1_update_tld_names_command" "test_2_update_tld_names_module" - ]); + ]; - checkPhase = '' - export PATH="$PATH:$out/bin" - py.test -k '${disabledTests}' + preCheck = '' + export PATH="$PATH:$out/bin" ''; + dontUseSetuptoolsCheck = true; + + pythonImportsCheck = [ + "tld" + ]; + meta = with stdenv.lib; { homepage = https://github.com/barseghyanartur/tld; description = "Extracts the top level domain (TLD) from the URL given";