pythonPackages.setuptools: Remove windows files and make reproducible
- setuptools includes *.exe files by default, but can be excluded with an ENV variable. - setuptools was built as an egg, which had reproducibility problems. Instead use a wheel These are various *.exe and *.xml files used only on windows. setuptools includes them by default since it normally creates a single release for all operating systems. This reduces the size from 1020.0K to 801.6K according to `nix-path -sh`. The egg is a zip file. setuptools leaves timestamps in the egg, which makes the build unreproducible. Unfortunately the files aren't compressed so the size of setuptools increases to 2.3M from 0.8M according to `nix path-info -sh`. With this change, setuptools is reproducible according to nix-build -A python37Packages.setuptools --check
This commit is contained in:
parent
dd6261cabe
commit
90be4c2c78
@ -6,11 +6,17 @@
|
|||||||
, unzip
|
, unzip
|
||||||
, callPackage
|
, callPackage
|
||||||
, bootstrapped-pip
|
, bootstrapped-pip
|
||||||
|
, lib
|
||||||
|
, pipInstallHook
|
||||||
|
, setuptoolsBuildHook
|
||||||
}:
|
}:
|
||||||
|
|
||||||
buildPythonPackage rec {
|
buildPythonPackage rec {
|
||||||
pname = "setuptools";
|
pname = "setuptools";
|
||||||
version = "41.2.0";
|
version = "41.2.0";
|
||||||
|
# Because of bootstrapping we don't use the setuptoolsBuildHook that comes with format="setuptools" directly.
|
||||||
|
# Instead, we override it to remove setuptools to avoid a circular dependency.
|
||||||
|
# The same is done for pip and the pipInstallHook.
|
||||||
format = "other";
|
format = "other";
|
||||||
|
|
||||||
src = fetchPypi {
|
src = fetchPypi {
|
||||||
@ -19,19 +25,18 @@ buildPythonPackage rec {
|
|||||||
sha256 = "66b86bbae7cc7ac2e867f52dc08a6bd064d938bac59dfec71b9b565dd36d6012";
|
sha256 = "66b86bbae7cc7ac2e867f52dc08a6bd064d938bac59dfec71b9b565dd36d6012";
|
||||||
};
|
};
|
||||||
|
|
||||||
# There is nothing to build
|
nativeBuildInputs = [
|
||||||
dontBuild = true;
|
bootstrapped-pip
|
||||||
|
(pipInstallHook.override{pip=null;})
|
||||||
|
(setuptoolsBuildHook.override{setuptools=null; wheel=null;})
|
||||||
|
];
|
||||||
|
|
||||||
nativeBuildInputs = [ bootstrapped-pip ];
|
preBuild = lib.strings.optionalString (!stdenv.hostPlatform.isWindows) ''
|
||||||
|
export SETUPTOOLS_INSTALL_WINDOWS_SPECIFIC_FILES=0
|
||||||
installPhase = ''
|
|
||||||
dst=$out/${python.sitePackages}
|
|
||||||
mkdir -p $dst
|
|
||||||
export PYTHONPATH="$dst:$PYTHONPATH"
|
|
||||||
${python.pythonForBuild.interpreter} setup.py install --prefix=$out
|
|
||||||
wrapPythonPrograms
|
|
||||||
'';
|
'';
|
||||||
|
|
||||||
|
pipInstallFlags = [ "--ignore-installed" ];
|
||||||
|
|
||||||
# Adds setuptools to nativeBuildInputs causing infinite recursion.
|
# Adds setuptools to nativeBuildInputs causing infinite recursion.
|
||||||
catchConflicts = false;
|
catchConflicts = false;
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user