From 8c75363c719f1ac161a295f240dedf339863f092 Mon Sep 17 00:00:00 2001 From: Peter Simons Date: Wed, 7 May 2014 22:13:26 +0200 Subject: [PATCH] The logic behind 'libiconvOrLibc' is flawed and that attribute should be removed. See https://github.com/NixOS/nixpkgs/pull/2532 for further details. --- pkgs/top-level/all-packages.nix | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index bd39b080d4c..f81dc83491b 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -5085,6 +5085,9 @@ let then null else libiconv; + # The logic behind this attribute is broken: libiconvOrNull==null does + # NOT imply libiconv=glibc! On Darwin, for example, we have a native + # libiconv library which is not glibc. libiconvOrLibc = if libiconvOrNull == null then gcc.libc else libiconv; # On non-GNU systems we need GNU Gettext for libintl.