From 89cb93aefed79d51ed05d42a2caaadf2a18148e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Sch=C3=BCtz?= Date: Sun, 24 Jan 2021 18:20:34 +0100 Subject: [PATCH] brackets: drop Hasn't been updated since 2017 and suffers from CVE-2019-8255. --- .../applications/editors/brackets/default.nix | 58 ------------------- pkgs/top-level/aliases.nix | 1 + pkgs/top-level/all-packages.nix | 2 - 3 files changed, 1 insertion(+), 60 deletions(-) delete mode 100644 pkgs/applications/editors/brackets/default.nix diff --git a/pkgs/applications/editors/brackets/default.nix b/pkgs/applications/editors/brackets/default.nix deleted file mode 100644 index 95bf6f6d7aa..00000000000 --- a/pkgs/applications/editors/brackets/default.nix +++ /dev/null @@ -1,58 +0,0 @@ -{ stdenv, lib, fetchurl, gtk2, glib, gdk-pixbuf, alsaLib, nss, nspr, gconf -, cups, libgcrypt_1_5, systemd, dbus, libXdamage, expat }: -with lib; - -let - bracketsLibs = makeLibraryPath [ - gtk2 glib gdk-pixbuf stdenv.cc.cc.lib alsaLib nss nspr gconf cups libgcrypt_1_5 dbus systemd libXdamage expat - ]; -in -stdenv.mkDerivation rec { - pname = "brackets"; - version = "1.9"; - - src = fetchurl { - url = "https://github.com/adobe/brackets/releases/download/release-${version}/Brackets.Release.${version}.64-bit.deb"; - sha256 = "0c4l2rr0853xd21kw8hhxlmrx8mqwb7iqa2k24zvwyjp4nnwkgbp"; - name = "${pname}-${version}.deb"; - }; - - phases = [ "installPhase" "fixupPhase" ]; - - installPhase = '' - mkdir -p $out - ar p $src data.tar.xz | tar -C $out -xJ - - mv $out/usr/* $out/ - rmdir $out/usr - ln -sf $out/opt/brackets/brackets $out/bin/brackets - - ln -s ${lib.getLib systemd}/lib/libudev.so.1 $out/opt/brackets/lib/libudev.so.0 - - substituteInPlace $out/opt/brackets/brackets.desktop \ - --replace "Exec=/opt/brackets/brackets" "Exec=brackets" - mkdir -p $out/share/applications - ln -s $out/opt/brackets/brackets.desktop $out/share/applications/ - ''; - - postFixup = '' - patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" \ - --set-rpath "${bracketsLibs}:$out/opt/brackets/lib" \ - $out/opt/brackets/Brackets - - patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" \ - --set-rpath "${bracketsLibs}" \ - $out/opt/brackets/Brackets-node - - patchelf --set-rpath "${bracketsLibs}" \ - $out/opt/brackets/lib/libcef.so - ''; - - meta = { - description = "An open source code editor for the web, written in JavaScript, HTML and CSS"; - homepage = "http://brackets.io/"; - license = licenses.mit; - maintainers = [ maintainers.matejc ]; - platforms = [ "x86_64-linux" ]; - }; -} diff --git a/pkgs/top-level/aliases.nix b/pkgs/top-level/aliases.nix index 7d3332c3a7c..43bf489b0e5 100644 --- a/pkgs/top-level/aliases.nix +++ b/pkgs/top-level/aliases.nix @@ -70,6 +70,7 @@ mapAliases ({ bazaarTools = throw "bazaar has been deprecated by breezy."; # added 2020-04-19 beegfs = throw "beegfs has been removed."; # added 2019-11-24 bluezFull = bluez; # Added 2019-12-03 + brackets = throw "brackets has been removed, it was unmaintained and had open vulnerabilities"; # added 2021-01-24 bridge_utils = bridge-utils; # added 2015-02-20 bro = zeek; # added 2019-09-29 bootchart = throw "bootchart has been removed from nixpkgs, as it is without a maintainer"; # added 2019-12-10 diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 71ec34213a3..d1734467d56 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -21119,8 +21119,6 @@ in bonzomatic = callPackage ../applications/editors/bonzomatic { }; - brackets = callPackage ../applications/editors/brackets { gconf = gnome2.GConf; }; - brave = callPackage ../applications/networking/browsers/brave { }; break-time = callPackage ../applications/misc/break-time { };