public/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Per reviewer request, cast the other side.

Browse Source 
I don't think this matters.  As long as one or the other of these is
a std::string, I get an operator== that looks at content rather than
pointer equality.  I picked casting the constant over casting the dynamic
thing in hopes that the compiler would have a better chance at optimizing
away any runtime cost.

Deferring to reviewer.
This commit is contained in:
Chuck 2019-09-16 08:44:33 -07:00 committed by Linus Heckemann
parent aa8e1d5f1e
commit 88183eb484
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nixos/modules/installer/tools/nixos-option/nixos-option.cc
View File

@ -140,7 +140,7 @@ bool isOption(Context * ctx, const Value & v)
if (evaluated_type.type != tString) { if (evaluated_type.type != tString) {
return false; return false;
} }
return evaluated_type.string.s == static_cast<std::string>("option"); return static_cast<std::string>(evaluated_type.string.s) == "option";
} catch (Error &) { } catch (Error &) {
return false; return false;
} }