Merge pull request #105379 from NixOS/fix-buildRustCrateTests

tests.buildRustCrate: Fix after hashing method change
This commit is contained in:
John Ericson 2020-12-19 14:49:21 -05:00 committed by GitHub
commit 86c1825fc1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 7 deletions

View File

@ -146,12 +146,18 @@ let
}; };
in in
runCommand "assert-outputs-${name}" { runCommand "assert-outputs-${name}" {
} '' } (''
local actualFiles=$(mktemp) local actualFiles=$(mktemp)
cd "${crateOutput}" cd "${crateOutput}"
find . -type f | sort >$actualFiles find . -type f \
diff -q ${expectedFilesFile} $actualFiles >/dev/null || { | sort \
''
# sed out the hash because it differs per platform
+ ''
| sed -E -e 's/-[0-9a-fA-F]{10}\.rlib/-HASH.rlib/g' \
> "$actualFiles"
diff -q ${expectedFilesFile} "$actualFiles" > /dev/null || {
echo -e "\033[0;1;31mERROR: Difference in expected output files in ${crateOutput} \033[0m" >&2 echo -e "\033[0;1;31mERROR: Difference in expected output files in ${crateOutput} \033[0m" >&2
echo === Got: echo === Got:
sed -e 's/^/ /' $actualFiles sed -e 's/^/ /' $actualFiles
@ -164,7 +170,7 @@ let
exit 1 exit 1
} }
touch $out touch $out
'' '')
; ;
in rec { in rec {
@ -594,7 +600,7 @@ let
}; };
expectedFiles = [ expectedFiles = [
"./nix-support/propagated-build-inputs" "./nix-support/propagated-build-inputs"
"./lib/libtest_lib-042a1fdbef.rlib" "./lib/libtest_lib-HASH.rlib"
"./lib/link" "./lib/link"
]; ];
}; };
@ -611,7 +617,7 @@ let
}; };
expectedFiles = [ expectedFiles = [
"./nix-support/propagated-build-inputs" "./nix-support/propagated-build-inputs"
"./lib/libtest_lib-042a1fdbef.rlib" "./lib/libtest_lib-HASH.rlib"
"./lib/link" "./lib/link"
]; ];
}; };

View File

@ -39,6 +39,7 @@ with pkgs;
cross = callPackage ./cross {}; cross = callPackage ./cross {};
rustCustomSysroot = callPackage ./rust-sysroot {}; rustCustomSysroot = callPackage ./rust-sysroot {};
buildRustCrate = callPackage ../build-support/rust/build-rust-crate/test { };
nixos-functions = callPackage ./nixos-functions {}; nixos-functions = callPackage ./nixos-functions {};

View File

@ -10071,7 +10071,6 @@ in
buildRustCrate = callPackage ../build-support/rust/build-rust-crate { }; buildRustCrate = callPackage ../build-support/rust/build-rust-crate { };
buildRustCrateHelpers = callPackage ../build-support/rust/build-rust-crate/helpers.nix { }; buildRustCrateHelpers = callPackage ../build-support/rust/build-rust-crate/helpers.nix { };
buildRustCrateTests = recurseIntoAttrs (callPackage ../build-support/rust/build-rust-crate/test { });
cratesIO = callPackage ../build-support/rust/crates-io.nix { }; cratesIO = callPackage ../build-support/rust/crates-io.nix { };
cargo-web = callPackage ../development/tools/cargo-web { cargo-web = callPackage ../development/tools/cargo-web {