From 86b695a18e2a228b88387246107340a1bf6ae275 Mon Sep 17 00:00:00 2001 From: aszlig Date: Tue, 4 Aug 2015 03:03:24 +0200 Subject: [PATCH] vbox-guest: Remove all references to sbin/. Using $storepath/sbin is deprecated according to commit 98cedb3, so let's avoid putting anything in .../sbin for the guest additions. This is a continuation of the initial commit done by @ctheune at 1fb1360, which unfortunately broke VM tests and only changed the path of the mount.vboxsf helper. With this commit, the VM test is fixed and I've also verified on my machine that it is indeed working again. Signed-off-by: aszlig --- nixos/modules/virtualisation/virtualbox-guest.nix | 2 +- nixos/tests/virtualbox.nix | 4 ++-- .../virtualization/virtualbox/guest-additions/default.nix | 6 ++---- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/nixos/modules/virtualisation/virtualbox-guest.nix b/nixos/modules/virtualisation/virtualbox-guest.nix index a0e4bd558e0..6c4014fc4a1 100644 --- a/nixos/modules/virtualisation/virtualbox-guest.nix +++ b/nixos/modules/virtualisation/virtualbox-guest.nix @@ -54,7 +54,7 @@ in unitConfig.ConditionVirtualization = "oracle"; - serviceConfig.ExecStart = "@${kernel.virtualboxGuestAdditions}/sbin/VBoxService VBoxService --foreground"; + serviceConfig.ExecStart = "@${kernel.virtualboxGuestAdditions}/bin/VBoxService VBoxService --foreground"; }; services.xserver.videoDrivers = mkOverride 50 [ "virtualbox" ]; diff --git a/nixos/tests/virtualbox.nix b/nixos/tests/virtualbox.nix index f94d219aba6..4895eb134dc 100644 --- a/nixos/tests/virtualbox.nix +++ b/nixos/tests/virtualbox.nix @@ -8,7 +8,7 @@ import ./make-test.nix ({ pkgs, ... }: with pkgs.lib; let #!${pkgs.stdenv.shell} -xe export PATH="${pkgs.coreutils}/bin:${pkgs.utillinux}/bin" - ${pkgs.linuxPackages.virtualboxGuestAdditions}/sbin/VBoxService + ${pkgs.linuxPackages.virtualboxGuestAdditions}/bin/VBoxService ${(attrs.vmScript or (const "")) pkgs} i=0 @@ -39,7 +39,7 @@ import ./make-test.nix ({ pkgs, ... }: with pkgs.lib; let ]; boot.initrd.extraUtilsCommands = '' - copy_bin_and_libs "${pkgs.linuxPackages.virtualboxGuestAdditions}/sbin/mount.vboxsf" + copy_bin_and_libs "${pkgs.linuxPackages.virtualboxGuestAdditions}/bin/mount.vboxsf" copy_bin_and_libs "${pkgs.utillinux}/bin/unshare" ${(attrs.extraUtilsCommands or (const "")) pkgs} ''; diff --git a/pkgs/applications/virtualization/virtualbox/guest-additions/default.nix b/pkgs/applications/virtualization/virtualbox/guest-additions/default.nix index ac447fd50d3..6bf0ef2e825 100644 --- a/pkgs/applications/virtualization/virtualbox/guest-additions/default.nix +++ b/pkgs/applications/virtualization/virtualbox/guest-additions/default.nix @@ -87,10 +87,8 @@ stdenv.mkDerivation { sed -i -e "s|/usr/bin|$out/bin|" bin/VBoxClient-all # Install binaries - mkdir -p $out/bin - install -m 4755 lib/VBoxGuestAdditions/mount.vboxsf $out/bin/mount.vboxsf - mkdir -p $out/sbin - install -m 755 sbin/VBoxService $out/sbin + install -D -m 4755 lib/VBoxGuestAdditions/mount.vboxsf $out/bin/mount.vboxsf + install -D -m 755 sbin/VBoxService $out/bin/VBoxService mkdir -p $out/bin install -m 755 bin/VBoxClient $out/bin