From 863982d2721b3bbb8d82a2cc9766944a90e21db0 Mon Sep 17 00:00:00 2001 From: Michael Weiss Date: Thu, 28 Jan 2021 15:34:34 +0100 Subject: [PATCH] chromium: Fix the version comparison in print_updates() I forgot that string comparison isn't enough because e.g.: >>> "89.0.4389.9" < "89.0.4389.23" False distutils.version.LooseVersion is undocumented but it works and is already available so why not use it: >>> LooseVersion("89.0.4389.9") < LooseVersion("89.0.4389.23") True --- pkgs/applications/networking/browsers/chromium/update.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkgs/applications/networking/browsers/chromium/update.py b/pkgs/applications/networking/browsers/chromium/update.py index 314d000e08a..ec656ef8527 100755 --- a/pkgs/applications/networking/browsers/chromium/update.py +++ b/pkgs/applications/networking/browsers/chromium/update.py @@ -13,6 +13,7 @@ import sys from codecs import iterdecode from collections import OrderedDict from datetime import datetime +from distutils.version import LooseVersion from os.path import abspath, dirname from urllib.request import urlopen @@ -122,7 +123,7 @@ def print_updates(channels_old, channels_new): for channel_name in channels_old: version_old = channels_old[channel_name]["version"] version_new = channels_new[channel_name]["version"] - if version_old < version_new: + if LooseVersion(version_old) < LooseVersion(version_new): attr_name = channel_name_to_attr_name(channel_name) print(f'- {attr_name}: {version_old} -> {version_new}')