From 85aa14fa373c5986d0aa08d66461c8c38458b16d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= Date: Tue, 6 Jun 2017 00:24:11 +0100 Subject: [PATCH] rssguard: use fetchgit; wrapGAppsHook --- .../feedreaders/rssguard/default.nix | 21 +++++++------------ pkgs/top-level/all-packages.nix | 1 - 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/pkgs/applications/networking/feedreaders/rssguard/default.nix b/pkgs/applications/networking/feedreaders/rssguard/default.nix index 0c17485b27b..a9e3c1d74e2 100644 --- a/pkgs/applications/networking/feedreaders/rssguard/default.nix +++ b/pkgs/applications/networking/feedreaders/rssguard/default.nix @@ -1,26 +1,19 @@ -{ stdenv, fetchFromGitHub, qmakeHook, qtwebengine, qttools }: +{ stdenv, fetchgit, qmakeHook, qtwebengine, qttools, wrapGAppsHook }: stdenv.mkDerivation rec { name = "rssguard-${version}"; version = "3.4.0"; - src = fetchFromGitHub { - owner = "martinrotter"; - repo = "rssguard"; - # fetchFromGitHub doesn't support rev being a tag when fetchSubmodules=true, - # so need to use the hash commit. See: - # https://github.com/NixOS/nixpkgs/issues/26302 - #rev = "${version}"; - rev = "cb15ba92c9bc1b80e2b81d7976438e562ee1ef90"; + src = fetchgit { + url = https://github.com/martinrotter/rssguard; + rev = "refs/tags/${version}"; sha256 = "1cdpfjj2lm1q2qh0w0mh505blcmi4n78458d3z3c1zn9ls9b9zsp"; fetchSubmodules = true; }; - buildInputs = [ qmakeHook qtwebengine qttools ]; - - preConfigure = '' - qmakeFlags="$qmakeFlags CONFIG+=release" - ''; + buildInputs = [ qtwebengine qttools ]; + nativeBuildInputs = [ qmakeHook wrapGAppsHook ]; + qmakeFlags = [ "CONFIG+=release" ]; meta = with stdenv.lib; { description = "Simple RSS/Atom feed reader with online synchronization"; diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index c148252df66..2ace6bb8ace 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -15163,7 +15163,6 @@ with pkgs; polybar = callPackage ../applications/misc/polybar { }; rssguard = libsForQt5.callPackage ../applications/networking/feedreaders/rssguard { }; - #rssguard = libsForQt5.callPackage ../applications/networking/newsreaders/rssguard { }; scudcloud = callPackage ../applications/networking/instant-messengers/scudcloud { };