public/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

* During shutdown, warn explicitly about filesystems that could not be

Browse Source 
unmounted or remounted read-only.
* Don't try to unmount / or /nix/store.

svn path=/nixos/branches/boot-order/; revision=22181
This commit is contained in:
Eelco Dolstra 2010-06-08 11:52:16 +00:00
parent 23cc979f61
commit 7c3ae9e716
1 changed files with 22 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
modules/system/upstart-events/shutdown.nix
View File

@ -69,31 +69,19 @@ with pkgs.lib;
swapoff -a swapoff -a
# Unmount helper functions.
getMountPoints() {
cat /proc/mounts \
| grep -v '^rootfs' \
| sed 's|^[^ ]\+ \+\([^ ]\+\).*|\1|' \
| grep -v '/proc\|/sys\|/dev'
}
getDevice() {
local mountPoint=$1
cat /proc/mounts \
| grep -v '^rootfs' \
| grep "^[^ ]\+ \+$mountPoint \+" \
| sed 's|^\([^ ]\+\).*|\1|'
}
# Unmount file systems. We repeat this until no more file systems # Unmount file systems. We repeat this until no more file systems
# can be unmounted. This is to handle loopback devices, file # can be unmounted. This is to handle loopback devices, file
# systems mounted on other file systems and so on. # systems mounted on other file systems and so on.
tryAgain=1 tryAgain=1
while test -n "$tryAgain"; do while test -n "$tryAgain"; do
tryAgain= tryAgain=
failed= # list of mount points that couldn't be unmounted/remounted
for mp in $(getMountPoints); do
device=$(getDevice $mp) cp /proc/mounts /dev/.mounts # don't read /proc/mounts while it's changing
exec 4< /dev/.mounts
while read -u 4 device mp fstype options rest; do
if [ "$mp" = /proc -o "$mp" = /sys -o "$mp" = /dev -o "$device" = "rootfs" -o "$mp" = /var/run/nscd ]; then continue; fi
echo "unmounting $mp..." echo "unmounting $mp..."
# We need to remount,ro before attempting any # We need to remount,ro before attempting any
@ -103,27 +91,31 @@ with pkgs.lib;
# `-i' is to workaround a bug in mount.cifs (it # `-i' is to workaround a bug in mount.cifs (it
# doesn't recognise the `remount' option, and # doesn't recognise the `remount' option, and
# instead mounts the FS again). # instead mounts the FS again).
mount -t none -n -i -o remount,ro none "$mp" success=
if mount -t "$fstype" -n -i -o remount,ro "device" "$mp"; then success=1; fi
# Note: don't use `umount -f'; it's very buggy. # Note: don't use `umount -f'; it's very buggy.
# (For instance, when applied to a bind-mount it # (For instance, when applied to a bind-mount it
# unmounts the target of the bind-mount.) !!! But # unmounts the target of the bind-mount.) !!! But
# we should use `-f' for NFS. # we should use `-f' for NFS.
if umount -n "$mp"; then if [ "$mp" != / -a "$mp" != /nix/store ]; then
if test "$mp" != /; then tryAgain=1; fi if umount -n "$mp"; then success=1; tryAgain=1; fi
fi
# Hack: work around a bug in mount (mount -o remount on a
# loop device forgets the loop=/dev/loopN entry in
# /etc/mtab).
if echo "$device" | grep -q '/dev/loop'; then
echo "removing loop device $device..."
losetup -d "$device"
fi fi
if [ -z "$success" ]; then failed="$failed $mp"; fi
done done
done done
# Warn about filesystems that could not be unmounted or
# remounted read-only.
if [ -n "$failed" ]; then
echo "warning: the following filesystems could not be unmounted:"
for mp in $failed; do echo " $mp"; done
sleep 5
fi
# Final sync. # Final sync.
sync sync