diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 788d40747fd..a36547af80d 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -203,11 +203,38 @@ with pkgs; fetchCrate = callPackage ../build-support/rust/fetchcrate.nix { }; - fetchFromGitHub = { owner, repo, rev, sha256 }: fetchzip { - name = "source"; - url = "https://github.com/${owner}/${repo}/archive/${rev}.zip"; - inherit sha256; - }; + fetchFromGitHub = { + owner, repo, rev, name ? "source", + fetchSubmodules ? false, private ? false, + githubBase ? "github.com", varPrefix ? null, + ... # For hash agility + }@args: assert private -> !fetchSubmodules; + let + baseUrl = "https://${githubBase}/${owner}/${repo}"; + passthruAttrs = removeAttrs args [ "owner" "repo" "rev" "fetchSubmodules" "private" "githubBase" "varPrefix" ]; + varBase = "NIX${if varPrefix == null then "" else "_${varPrefix}"}_GITHUB_PRIVATE_"; + # We prefer fetchzip in cases we don't need submodules as the hash + # is more stable in that case. + fetcher = if fetchSubmodules then fetchgit else fetchzip; + privateAttrs = lib.optionalAttrs private { + netrcPhase = '' + if [ -z "''$${varBase}USERNAME" -o -z "''$${varBase}PASSWORD" ]; then + echo "Error: Private fetchFromGitHub requires the nix building process (nix-daemon in multi user mode) to have the ${varBase}USERNAME and ${varBase}PASSWORD env vars set." >&2 + exit 1 + fi + cat > netrc <