bloaty: 2016-12-28 -> 2017-10-05

* use fetchFromGitHub now that it supports submodules
* change version style to dashes per guidelines
  (https://nixos.org/nixpkgs/manual/#sec-package-naming)
* cmake
* prefer substituteInPlace
* run tests

pkgs/development/tools/bloaty/default.nix

@@ -1,22 +1,31 @@
-{ stdenv, binutils, fetchgit }:
+{ stdenv, binutils, cmake, fetchFromGitHub }:
 
 stdenv.mkDerivation rec {
-  version = "2016.12.28";
+  version = "2017-10-05";
   name = "bloaty-${version}";
 
-  src = fetchgit {
+  src = fetchFromGitHub {
-    url = "https://github.com/google/bloaty.git";
+    owner = "google";
-    rev = "2234386bcee7297dfa1b6d8a5d20f95ea4ed9bb0";
+    repo = "bloaty";
-    sha256 = "0cfsjgbp9r16d6qi8v4k609bbhjff4vhdiapfkhr34z1cik1md4l";
+    rev = "e47b21b01ceecf001e1965e9da249d48d86a1749";
+    sha256 = "1il3z49hi0b07agjwr5fg1wzysfxsamfv1snvlp33vrlyl1m7cbm";
     fetchSubmodules = true;
   };
 
+  nativeBuildInputs = [ cmake ];
+
   enableParallelBuilding = true;
 
-  configurePhase = ''
+  preConfigure = ''
-    sed -i 's,c++filt,${binutils}/bin/c++filt,' src/bloaty.cc
+    substituteInPlace src/bloaty.cc \
+      --replace "c++filt" \
+                "${stdenv.lib.getBin binutils}/bin/c++filt"
   '';
 
+  doCheck = true;
+
+  checkPhase = "ctest";
+
   installPhase = ''
     install -Dm755 {.,$out/bin}/bloaty
   '';