From 4a58f744f17d6a63fc8437c9d1ee83e22d6eb928 Mon Sep 17 00:00:00 2001 From: Samuel Dionne-Riel Date: Fri, 9 Nov 2018 13:52:26 -0500 Subject: [PATCH 1/2] libreoffice-*: inherits meta. This ensures the package listing shows the expected informations. --- pkgs/applications/office/libreoffice/wrapper.nix | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkgs/applications/office/libreoffice/wrapper.nix b/pkgs/applications/office/libreoffice/wrapper.nix index 8566bd76e1e..ce8910d76d4 100644 --- a/pkgs/applications/office/libreoffice/wrapper.nix +++ b/pkgs/applications/office/libreoffice/wrapper.nix @@ -13,4 +13,7 @@ in for i in $(ls "${libreoffice}/bin/"); do test "$i" = "soffice" || ln -s soffice "$out/bin/$(basename "$i")" done -'') // { inherit libreoffice dbus; } +'') // { + inherit libreoffice dbus; + meta = libreoffice.meta; +} From 1430f1c0d0d509465c587efca6435a2af4d9de7d Mon Sep 17 00:00:00 2001 From: Samuel Dionne-Riel Date: Fri, 9 Nov 2018 13:53:37 -0500 Subject: [PATCH 2/2] libreoffice-*: changes attributes structure for *-unwrapped libreoffice-unwrapped points to the same libreoffice than libreoffice. libreoffice-*-unwrapped exists for all versions This bring an incompatible change where a user using `libreoffice-unwrapped` hoping to use `fresh` would now be inadvertently be using `still`. --- pkgs/top-level/all-packages.nix | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 9e9ee8797ff..c27f0e036f5 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -17652,6 +17652,7 @@ with pkgs; librecad = callPackage ../applications/misc/librecad { }; libreoffice = hiPrio libreoffice-still; + libreoffice-unwrapped = libreoffice.libreoffice; libreoffice-args = { inherit (perlPackages) ArchiveZip IOCompress; @@ -17673,21 +17674,20 @@ with pkgs; }; }; - libreoffice-unwrapped = callPackage ../applications/office/libreoffice - (libreoffice-args // { - }); - libreoffice-still-unwrapped = callPackage ../applications/office/libreoffice/still.nix - (libreoffice-args // { - poppler = poppler_0_61; - }); - libreoffice-fresh = lowPrio (callPackage ../applications/office/libreoffice/wrapper.nix { - libreoffice = libreoffice-unwrapped; + libreoffice = callPackage ../applications/office/libreoffice + (libreoffice-args // { + }); }); + libreoffice-fresh-unwrapped = libreoffice-fresh.libreoffice; libreoffice-still = lowPrio (callPackage ../applications/office/libreoffice/wrapper.nix { - libreoffice = libreoffice-still-unwrapped; + libreoffice = callPackage ../applications/office/libreoffice/still.nix + (libreoffice-args // { + poppler = poppler_0_61; + }); }); + libreoffice-still-unwrapped = libreoffice-still.libreoffice; libvmi = callPackage ../development/libraries/libvmi { };